Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variable to avoid shadowing #455

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 12, 2023

Description

Subj. Follow up for #453 (comment)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <[email protected]>
@m1kola m1kola requested a review from a team as a code owner October 12, 2023 08:46
@m1kola m1kola mentioned this pull request Oct 12, 2023
4 tasks
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c24fdbc) 66.07% compared to head (133ad4e) 83.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #455       +/-   ##
===========================================
+ Coverage   66.07%   83.80%   +17.73%     
===========================================
  Files          23       23               
  Lines         846      846               
===========================================
+ Hits          559      709      +150     
+ Misses        203       94      -109     
+ Partials       84       43       -41     
Flag Coverage Δ
e2e 65.95% <0.00%> (-0.12%) ⬇️
unit 76.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/resolution/variables/bundle.go 100.00% <100.00%> (+23.52%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola requested a review from joelanford October 12, 2023 08:57
@joelanford joelanford added this pull request to the merge queue Oct 12, 2023
Merged via the queue into operator-framework:main with commit f178f75 Oct 12, 2023
12 checks passed
@m1kola m1kola deleted the renames branch October 12, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants