Fixes reading properties with the same type #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 84.42% 84.37% -0.06%
==========================================
Files 23 23
Lines 777 787 +10
==========================================
+ Hits 656 664 +8
- Misses 86 87 +1
- Partials 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m1kola
force-pushed
the
fixes_property_reading
branch
from
a340630 to
f4bcdad
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joelanford
reviewed
Sep 21, 2023
Some properties like `olm.package` only can appear in a bundle once and we currently handle this correctly. However properties such as `olm.gvk` and `olm.gvk.required` can be present multiple times in the list. The current implementation overrides all the instances with the one which is the last in the list. This modifies the code to be able to read in both cases. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
fixes_property_reading
branch
from
f4bcdad to
915505f
Compare
joelanford
approved these changes
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
…erator-framework#429) * change catalog-specific URL from full path to API endpoint ref solves operator-framework#427 and implements phase 1 of the CatalogD expandable interface. This phase just moves from `status.contentURL` to `status.baseURL`, and will be used to provide reference to the catalog-specific API instead of the full path to JSONLines-formatted content, plus tests and documentation. Signed-off-by: Jordan Keister <[email protected]> * sticking to catalog-centric reference, and updated type Signed-off-by: Jordan Keister <[email protected]> * remove some magic numbers Signed-off-by: Jordan Keister <[email protected]> * review reconciliation Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some properties like
olm.packageonly can appear in a bundle once and we currently handle this correctly.However properties such as
olm.gvkandolm.gvk.requiredcan be present multiple times in the list. The current implementation overrides all the instances with the one which is the last in the list.This modifies the code to be able to read in both cases.
Closes #258
Description
Reviewer Checklist