Optimises Bundle.MediaType() (#408 follow up)
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 27 27
Lines 1073 1073
=======================================
Hits 901 901
Misses 119 119
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Media type is an optional field and can be an empty string after looading. This change avoids unmarshalling every time we call MediaType() method by comparing to `nil`. If value is `nil` - we need to load. If anything else (even an empty string) we already lazy-loaded the value. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
loadMediaType_optimisation
branch
from
c8e1344 to
4543bea
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joelanford
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a followup to #408 (comment)
Media type is an optional field and can be an empty string after looading. This change avoids unmarshalling every time we call MediaType() method by comparing to
nil.If value is
nil- we need to load. If anything else (even an empty string) we already lazy-loaded the value.Reviewer Checklist