Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Updates #178

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Actions Updates #178

merged 1 commit into from
Apr 19, 2023

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Apr 19, 2023

Brings a bunch of our github actions back up to date to remove more deprecation warnings and also removes an unnecessary caching step since actions/setup-go@v4 does this by default.

I'll carry these changes over to rukpak as well if they work correctly :)

Brings a bunch of our github actions back up to date to remove more deprecation warnings and also removes an unnecessary caching step since actions/setup-go@v4 does this by default.

Signed-off-by: dtfranz <[email protected]>
@dtfranz
Copy link
Contributor Author

dtfranz commented Apr 19, 2023

/hold
until we make sure all the actions are running correctly

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. Should we open issues/PRs in our other active repos to do this everywhere?

@dtfranz
Copy link
Contributor Author

dtfranz commented Apr 19, 2023

Nice! Looks good to me. Should we open issues/PRs in our other active repos to do this everywhere?

Yes, that's a good idea. Some of these deprecation warnings will become blockers on May 31st. I'll take care of rukpak and I can take a look at OLM as well.

@dtfranz
Copy link
Contributor Author

dtfranz commented Apr 19, 2023

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@dtfranz dtfranz merged commit 5e79476 into operator-framework:main Apr 19, 2023
LalatenduMohanty pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants