Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add check for client in e2e #1529

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 17, 2024

Depending on how e2e is run, we may not have a k8s client available.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner December 17, 2024 16:00
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 854432d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6761a9421cfe4e00092e5007
😎 Deploy Preview https://deploy-preview-1529--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68%. Comparing base (d3f267a) to head (854432d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files          42       42           
  Lines        3271     3271           
=======================================
  Hits         2443     2443           
  Misses        652      652           
  Partials      176      176           
Flag Coverage Δ
e2e 52.15% <ø> (ø)
unit 57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Depending on how e2e is run, we may not have a k8s client available.

Signed-off-by: Todd Short <[email protected]>
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We need to do the same in the catalogd
and probably in the future have this logic as an utils / func to just re-use in any test

Thank you. That was a good thought

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@tmshort tmshort added this pull request to the merge queue Dec 17, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Dec 17, 2024

Ok, I'll make a corresponding change to catalogd.

@tmshort
Copy link
Contributor Author

tmshort commented Dec 17, 2024

See operator-framework/catalogd#485 @camilamacedo86 for the catalogd version

Merged via the queue into operator-framework:main with commit cd290ba Dec 17, 2024
18 checks passed
@tmshort tmshort deleted the skip-metrics branch December 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants