Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update doc to add lease for cluster extension sample #1488

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

rashmi43
Copy link
Contributor

Description

fixes: #1478

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@rashmi43 rashmi43 requested a review from a team as a code owner November 20, 2024 17:40
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 8db08a1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/673e1f1e37a4600008fdfd7e
😎 Deploy Preview https://deploy-preview-1488--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola changed the title :book update doc to add lease for cluster extension 📖 Update doc to add lease for cluster extension sample Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (7ffb2ea) to head (8db08a1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
+ Coverage   74.69%   74.73%   +0.03%     
==========================================
  Files          42       42              
  Lines        3241     3241              
==========================================
+ Hits         2421     2422       +1     
+ Misses        647      646       -1     
  Partials      173      173              
Flag Coverage Δ
e2e 52.32% <ø> (-0.10%) ⬇️
unit 57.20% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@tmshort tmshort added this pull request to the merge queue Nov 21, 2024
@tmshort tmshort removed this pull request from the merge queue due to a manual request Nov 21, 2024
@tmshort
Copy link
Contributor

tmshort commented Nov 21, 2024

Merging as this is a doc update.

@tmshort tmshort added this pull request to the merge queue Nov 21, 2024
Merged via the queue into operator-framework:main with commit c8179f3 Nov 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: example ClusterExtension is missing lease verbs
2 participants