Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update contributor docs #1472

Merged
merged 1 commit into from
Nov 15, 2024
Merged

📖 Update contributor docs #1472

merged 1 commit into from
Nov 15, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 15, 2024

Description

  • Removes mention of non-existing make targets
  • Updates kind create snippet with correct one

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Update contributor docs
5dfe543 
* Removes mention of non-existing make targets
* Updates `kind create` snippet with correct one

Signed-off-by: Mikalai Radchuk <[email protected]>
@m1kola m1kola requested a review from a team as a code owner November 15, 2024 14:29
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5dfe543
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67375ae312dfc80008626068
😎 Deploy Preview https://deploy-preview-1472--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

camilamacedo86
camilamacedo86 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (0931d5b) to head (5dfe543).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1472   +/-   ##
=======================================
  Coverage   74.73%   74.73%           
=======================================
  Files          42       42           
  Lines        3241     3241           
=======================================
  Hits         2422     2422           
  Misses        646      646           
  Partials      173      173
Flag Coverage Δ
e2e 52.32% <ø> (-0.10%) ⬇️
unit 57.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola added this pull request to the merge queue Nov 15, 2024
Merged via the queue into operator-framework:main with commit e16be6e Nov 15, 2024
18 checks passed
@m1kola m1kola deleted the fix_contribute_docs branch November 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Assignees

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1kola @camilamacedo86