Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: add local build and deploy instructions to CONTRIBUTING.md #1430

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

camilamacedo86
Copy link
Contributor

  • Added steps for building, loading Docker images, and deploying changes locally with Kind

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 6, 2024 20:15
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e950fb5
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/672be04700d6c000081b635f
😎 Deploy Preview https://deploy-preview-1430--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (6bda277) to head (392e191).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   73.42%   73.26%   -0.17%     
==========================================
  Files          42       42              
  Lines        3063     3063              
==========================================
- Hits         2249     2244       -5     
- Misses        641      644       +3     
- Partials      173      175       +2     
Flag Coverage Δ
e2e 54.91% <ø> (-0.43%) ⬇️
unit 52.59% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@camilamacedo86
Copy link
Contributor Author

Hi @tmshort

Thank you for your time and review.
All your suggestions are applied now.

- Added steps for building, loading Docker images, and deploying changes locally with Kind
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ^^

@perdasilva perdasilva added this pull request to the merge queue Nov 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
- Added steps for building, loading Docker images, and deploying changes locally with Kind
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@perdasilva perdasilva added this pull request to the merge queue Nov 7, 2024
Merged via the queue into operator-framework:main with commit 22004fa Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants