-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 [Docs] Document the granting of API access #1407
📖 [Docs] Document the granting of API access #1407
Conversation
Signed-off-by: Brett Tofel <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
- Coverage 73.43% 73.26% -0.18%
==========================================
Files 42 42
Lines 3200 3063 -137
==========================================
- Hits 2350 2244 -106
+ Misses 663 644 -19
+ Partials 187 175 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brett Tofel <[email protected]>
Fixes #1383 |
Signed-off-by: Brett Tofel <[email protected]>
I advocate for telling the story like this:
Right now, we have (1) at the end of the doc, and I kind of think that's burying the lead. |
Signed-off-by: Brett Tofel <[email protected]>
@joelanford check out the reordered document |
Co-authored-by: Camila Macedo <[email protected]>
Co-authored-by: Camila Macedo <[email protected]>
Co-authored-by: Camila Macedo <[email protected]>
Co-authored-by: Camila Macedo <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
/lgtm cancel to allow others review it |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions. Please feel free to take what is useful.
Please remember to update the mkdocs.yaml
so that the content appears in the table of contents.
Lastly, I would format the procedures a little differently, but this is not a blocking issue. After the PR merges, I will open a follow up PR to show you what I have in mind, and maybe we can use that to make a template for future use.
Great work!
Co-authored-by: Michael Peter <[email protected]>
Co-authored-by: Michael Peter <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
cc: @kuiwang02 ^^ |
Co-authored-by: Joe Lanford <[email protected]>
Co-authored-by: Joe Lanford <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
This review comment has been addressed.
8d535a6
Description
When operators or cluster extensions are installed through OLM, they often provide Custom Resource Definitions (CRDs) that expose new API resources. By default, cluster administrators may have full access to manage these resources, but non-admin users often require specific permissions to create, view, or edit these custom resource objects.
This PR adds a document to the Concepts dir to show how this works.
Fixes #1383
Reviewer Checklist