Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cache check #1202

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Sep 2, 2024

Description

There is a bug in the optimisation where we try to avoid writing, if another thread already updated the cache: I believe we should be checking catalog.Status.ResolvedSource.Image.ResolvedRef (includes sha) as in other places instead of catalog.Status.ResolvedSource.Image.Ref.

Related:

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <[email protected]>
@m1kola m1kola requested a review from a team as a code owner September 2, 2024 14:44
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 52392f2
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d5cf5cd1b2ba00089660a2
😎 Deploy Preview https://deploy-preview-1202--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (f40d9ca) to head (52392f2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/catalogmetadata/cache/cache.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files          36       36           
  Lines        1979     1979           
=======================================
  Hits         1535     1535           
  Misses        309      309           
  Partials      135      135           
Flag Coverage Δ
e2e 57.65% <0.00%> (ø)
unit 55.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola closed this Sep 3, 2024
@m1kola m1kola deleted the fix_client_ref_check branch September 3, 2024 12:09
@m1kola m1kola restored the fix_client_ref_check branch September 3, 2024 12:09
@m1kola m1kola reopened this Sep 3, 2024
@m1kola
Copy link
Member Author

m1kola commented Sep 3, 2024

Accidentally deleted the branch. Restored and reopened.

@everettraven everettraven added this pull request to the merge queue Sep 3, 2024
Merged via the queue into operator-framework:main with commit f4ea259 Sep 3, 2024
29 of 31 checks passed
@m1kola m1kola deleted the fix_client_ref_check branch September 3, 2024 14:27
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants