🌱 Update certificate code to be more strict #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
+ Coverage 72.94% 73.91% +0.96%
==========================================
Files 28 31 +3
Lines 1889 2028 +139
==========================================
+ Hits 1378 1499 +121
- Misses 378 387 +9
- Partials 133 142 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
force-pushed
the
cert-ut2
branch
3 times, most recently
from
3f5fdc5 to
1ec8ada
Compare
Deal with malformed PEM that is skipped by the golang standard library Signed-off-by: Todd Short <[email protected]>
joelanford
approved these changes
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
Deal with malformed PEM that is skipped by the golang standard library Signed-off-by: Todd Short <[email protected]>
perdasilva
pushed a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
Deal with malformed PEM that is skipped by the golang standard library Signed-off-by: Todd Short <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with malformed PEM that is skipped by the golang standard library
Description
Reviewer Checklist