Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e package tests #196

Closed
1 of 2 tasks
Tracked by #189
perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #545
Closed
1 of 2 tasks
Tracked by #189

Update e2e package tests #196

perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #545
Assignees
@tmshort
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@perdasilva
Copy link
Contributor

perdasilva commented May 9, 2023 •
edited by tmshort
Loading

Description

Follow the testing guidelines set forth in #188 and refactor the e2e package unit tests.

Pre-Conditions

Acceptance Criteria
@perdasilva perdasilva mentioned this issue May 9, 2023
Closed
8 tasks
@perdasilva perdasilva added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 9, 2023
@perdasilva perdasilva added this to OLM v1 May 9, 2023
@perdasilva perdasilva moved this to Todo in OLM v1 May 9, 2023
@perdasilva perdasilva changed the title update required package variable source tests Update required package variable source tests May 9, 2023
@matthew-hagemann matthew-hagemann mentioned this issue May 9, 2023
Closed
@tmshort tmshort self-assigned this Sep 7, 2023
@tmshort tmshort changed the title Update required package variable source tests Update e2e package tests Sep 7, 2023
@tmshort tmshort mentioned this issue Nov 16, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in OLM v1 Nov 27, 2023
LalatenduMohanty pushed a commit to LalatenduMohanty/operator-controller that referenced this issue Dec 19, 2024
@everettraven
(techdebt): refactor catalog controller unit tests (operator-framewor…
9f91fc5 
…k#196)

* (techdebt): refactor catalog controller unit tests

to no longer use Ginkgo and instead use
the native Go testing and testify

Signed-off-by: Bryce Palmer <[email protected]>

* remove rebase detritus, unnecessary IIFE, and featuregate comments/blocks. goimports.

Signed-off-by: Bryce Palmer <[email protected]>

---------

Signed-off-by: Bryce Palmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmshort tmshort

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
OLM v1
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Remove ginkgo from e2e tests tmshort/operator-controller
2 participants
@perdasilva @tmshort