add build info metric #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Dec 16, 2020
10 tasks
anmol372
force-pushed
the
build_info_metric
branch
from
abe7ce3 to
c136eac
Compare
joelanford
reviewed
Jan 12, 2021
estroz
reviewed
Jan 12, 2021
internal/version/version.go
Outdated
| GitCommit = "unknown" | ||
| Version = "unknown" | ||
| GitCommit = "unknown" | ||
| GitVersion = "unknown" |
There was a problem hiding this comment.
It's not. I'm actually looking at improving the version handling now. I think we should leave this PR open until we have better version number handling in place that accounts for both the main helm-operator binary and projects that import this repo and need to use the plugin to scaffold Makefile and Dockerfile with appropriate version numbers.
I think debug.ReadBuildInfo() may be useful to us.
joelanford
force-pushed
the
build_info_metric
branch
from
80ab2bf to
cbbf05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK update from: Build info metric: operator-framework/operator-sdk#4220