Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces #194, bumps ginkgo to 2.20.2, golang to 1.22 #195

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

grokspawn
Copy link
Contributor

No description provided.

@grokspawn grokspawn requested a review from a team as a code owner October 9, 2024 20:18
Signed-off-by: Jordan <[email protected]>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (6b2ca70) to head (8eea4dc).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6b2ca70) and HEAD (8eea4dc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6b2ca70) HEAD (8eea4dc)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   61.48%   53.45%   -8.03%     
==========================================
  Files          10       16       +6     
  Lines         540      666     +126     
==========================================
+ Hits          332      356      +24     
- Misses        192      294     +102     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor Author

Ah. Seen during go mod tidy after updating:

go: github.com/onsi/ginkgo/[email protected] requires go >= 1.22; switching to go1.22.8

@grokspawn grokspawn changed the title replaces #194, bumps ginkgo to 2.20.2 replaces #194, bumps ginkgo to 2.20.2, golang to 1.22 Oct 9, 2024
Copy link

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@grokspawn grokspawn enabled auto-merge October 9, 2024 20:48
Copy link

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grokspawn grokspawn added this pull request to the merge queue Oct 9, 2024
Merged via the queue into operator-framework:main with commit 149dd04 Oct 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants