⚠️ Remove getter methods from constraints #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 63.36% 63.77% +0.41%
==========================================
Files 10 10
Lines 464 461 -3
==========================================
Hits 294 294
+ Misses 154 151 -3
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
LGTM when ready! |
m1kola
force-pushed
the
remove_getters
branch
from
41e0617 to
4d16bb9
Compare
We export fields from constraints instead Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
remove_getters
branch
from
4d16bb9 to
682ee65
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@ncdc rebased on top of |
ncdc
approved these changes
Dec 4, 2023
Merged
via the queue into
operator-framework:main
with commit Dec 4, 2023
ddd4744
6 of 7 checks passed
m1kola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We export fields from constraints instead
Closes #154