Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Update Jaeger community-operators to v1.17.0 #1287

Conversation

jpkrohling
Copy link
Contributor

Thanks submitting your Operator. Please check below list before you create your Pull Request.


Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.


New Submissions

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need

2 For more information see here

@jpkrohling
Copy link
Contributor Author

cc @objectiser

@J0zi J0zi closed this Feb 28, 2020
@J0zi J0zi reopened this Feb 28, 2020
@openshift-ci-robot openshift-ci-robot added openshift-operator An Operator targeting OpenShift / OKD size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2020
@jpkrohling
Copy link
Contributor Author

CVP/operator-olm-deployment

Is this check failure expected, or is there something wrong with our CSV?

@J0zi J0zi self-assigned this Feb 28, 2020
@J0zi
Copy link
Collaborator

J0zi commented Feb 28, 2020

/test CVP

@jpkrohling jpkrohling changed the title Update Jaeger community-operators to v1.17.0 WIP -Update Jaeger community-operators to v1.17.0 Feb 28, 2020
@jpkrohling
Copy link
Contributor Author

Marking this as WIP, as I found a problem with this CSV, related to jaegertracing/jaeger-operator#931

@jpkrohling jpkrohling changed the title WIP -Update Jaeger community-operators to v1.17.0 WIP - Update Jaeger community-operators to v1.17.0 Feb 28, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2020
@jpkrohling jpkrohling changed the title WIP - Update Jaeger community-operators to v1.17.0 Update Jaeger community-operators to v1.17.0 Mar 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2020
@jpkrohling
Copy link
Contributor Author

Removing WIP.

@J0zi
Copy link
Collaborator

J0zi commented Mar 2, 2020

/test CVP

@jpkrohling
Copy link
Contributor Author

@J0zi, can we get the logs for the check that failed? All I can see is this:

Failed to deploy the operator with OLM: java.lang.Exception: Error running Ansible playbook 'deploy-olm-operator.yml': hudson.AbortException: script returned exit code 2

@J0zi
Copy link
Collaborator

J0zi commented Mar 3, 2020

I will give it another chance, we will see. Waiting for a result.

@J0zi
Copy link
Collaborator

J0zi commented Mar 3, 2020

/test CVP

@J0zi
Copy link
Collaborator

J0zi commented Mar 3, 2020

investigating

@J0zi
Copy link
Collaborator

J0zi commented Mar 3, 2020

@jpkrohling, it failed on the following:
TASK [deploy_olm_operator : Push the operator metadata to the private quay.io repository]

@jpkrohling
Copy link
Contributor Author

What does that mean? Is there something I have to fix in the CSV? During my manual tests, I was able to push this to my private quay.io repository and create an operator-source from it, and a subscription afterwards.

@gallettilance
Copy link
Member

@jpkrohling @J0zi can you double check that your validation schema is correct? That crd is very large and it seems to contain a lot of duplicate fields. Can you confirm that this file is correct?

@J0zi
Copy link
Collaborator

J0zi commented Mar 4, 2020

still investigating
ERROR:operatorcourier.push: 413 Request Entity Too Large
@jpkrohling, CRD has 21000 lines.

@jpkrohling
Copy link
Contributor Author

As part of jaegertracing/jaeger-operator#932 , we have recently removed the descriptions from the CRD, making it far smaller. I added another commit to this PR to use that CRD instead.

A similar PR to this one has been merged already, adding the Jaeger 1.17.0 CSV to the upstream community operators. To bring a similar change to that, I also created #1299, but this might be a sign that the tests between community operators and upstream community operators should be aligned.

@J0zi
Copy link
Collaborator

J0zi commented Mar 5, 2020

Hi @jpkrohling, currently, catalog-initialization fails on following:
fatal - error loading manifests from directory: error checking provided apis in bundle : couldn't find jaegertracing.io/v1/Jaeger (jaegers) in bundle. found: map[]"

@jpkrohling jpkrohling force-pushed the Update-Jaeger-community-operators-to-1.17.0 branch from 33b87d2 to aeb9f62 Compare March 5, 2020 09:43
@jpkrohling
Copy link
Contributor Author

Looks like it's now passing!

@J0zi
Copy link
Collaborator

J0zi commented Mar 5, 2020

@jpkrohling please squash your commits. And consider similar updates to #1299.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling force-pushed the Update-Jaeger-community-operators-to-1.17.0 branch from aeb9f62 to 32e5afd Compare March 5, 2020 12:34
@jpkrohling
Copy link
Contributor Author

And consider similar updates to #1299.

It is already in sync with this PR here.

@J0zi
Copy link
Collaborator

J0zi commented Mar 5, 2020

/test CVP

@J0zi J0zi merged commit fa51c10 into operator-framework:master Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
openshift-operator An Operator targeting OpenShift / OKD size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants