(feature) Implement polling image source in intervals #185

anik120 · 2023-10-06T13:56:16Z

Implements https://docs.google.com/document/d/1iWSrWL9pYRJ5Ua3VYErkK1Q2lAusBUeDCh66Ew4lDbQ/edit?usp=sharing

Closes #180

anik120 · 2023-10-06T13:58:55Z

Based off of #145. Commit to review: 4764cd9

codecov · 2023-10-06T14:00:54Z

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (bd8cfbd) 46.15% compared to head (388d040) 39.70%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   46.15%   39.70%   -6.46%     
==========================================
  Files           6        8       +2     
  Lines         364      471     +107     
==========================================
+ Hits          168      187      +19     
- Misses        177      265      +88     
  Partials       19       19

Files	Coverage Δ
api/core/v1alpha1/catalog_types.go	`100.00% <ø> (ø)`
internal/source/image_registry_client.go	`67.07% <100.00%> (+0.40%)`	⬆️
internal/source/unpacker.go	`0.00% <ø> (ø)`
pkg/controllers/core/catalog_controller.go	`80.50% <100.00%> (+3.28%)`	⬆️
api/core/v1alpha1/zz_generated.deepcopy.go	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/e2e/cel_validation_test.go

api/core/v1alpha1/catalog_types.go

internal/source/image_registry_client.go

internal/source/image_registry_client_test.go

internal/source/unpacker.go

pkg/controllers/core/catalog_controller.go

api/core/v1alpha1/catalog_types.go

cmd/manager/main.go

config/manager/manager.yaml

config/samples/core_v1alpha1_catalog.yaml

internal/source/image_registry_client.go

pkg/controllers/core/catalog_controller.go

api/core/v1alpha1/catalog_types.go

pkg/controllers/core/catalog_controller.go

api/core/v1alpha1/catalog_types.go

pkg/controllers/core/catalog_controller.go

api/core/v1alpha1/catalog_types.go

ncdc · 2023-10-18T18:45:01Z

pkg/controllers/core/catalog_controller.go

+	if catalog.Spec.Source.Image.PollInterval == nil {
+		return false
+	}
+	// if it's not time to poll yet, and the CR wasn't changed don't unpack again


This works as-is, but for future reference, it's often much easier to reason about a series of simple if conditions vs. a combination of conditions. Specifically, I find this easier:

if catalog.Generation != catalog.Status.ObservedGeneration { return true } if nextPoll.After(time.Now()) { return true } return false

pkg/controllers/core/catalog_controller_test.go

api/core/v1alpha1/catalog_types.go

pkg/controllers/core/catalog_controller_test.go

Implements https://docs.google.com/document/d/1iWSrWL9pYRJ5Ua3VYErkK1Q2lAusBUeDCh66Ew4lDbQ/edit?usp=sharing Closes operator-framework#180 Signed-off-by: Anik Bhattacharjee <[email protected]>

…work#185) Implements https://docs.google.com/document/d/1iWSrWL9pYRJ5Ua3VYErkK1Q2lAusBUeDCh66Ew4lDbQ/edit?usp=sharing Closes operator-framework#180 Signed-off-by: Anik Bhattacharjee <[email protected]>

anik120 requested a review from a team as a code owner October 6, 2023 13:56

anik120 self-assigned this Oct 6, 2023

anik120 marked this pull request as draft October 6, 2023 13:57

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023

anik120 force-pushed the poll branch from 4764cd9 to 3acf26b Compare October 6, 2023 13:59