Add metrics to the catalog server #156
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 3 3
Lines 215 215
=======================================
Hits 170 170
Misses 28 28
Partials 17 17 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
everettraven
force-pushed
the
feature/server-metrics
branch
from
dbb9540 to
efa5262
Compare
that can be used for calculating the Apdex Score and assess the health of the http server that is serving catalog contents to clients Signed-off-by: Bryce Palmer <[email protected]>
everettraven
force-pushed
the
feature/server-metrics
branch
from
7fcb6ea to
1c56928
Compare
everettraven
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
| // calculate Apdex Scores up to a T of 1 second, but using various mathmatical formulas we | ||
| // should be able to estimate Apdex Scores up to a T of 2.5. Having a larger range of buckets | ||
| // will allow us to more easily calculate health indicators other than the Apdex Score. | ||
| Buckets: []float64{0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1, 1.2, 1.6, 2, 2.4, 2.8, 3.2, 3.6, 4, 10}, |
There was a problem hiding this comment.
Does it matter that our write timeout is 10s and the max bucket duration is 10s?
Seems like we'll only ever get whatever error code maps to that timeout in the 10s bucket.
There was a problem hiding this comment.
I don't think so. If anything I think it means that we now have buckets that capture all possible response times and that allows us to calculate more metrics on the fly. This is all going based on #156 (comment) . Since if no requests take more than 10s we will never have anything in the "Inf" bucket.
That being said, I could be wrong - I don't have enough experience in this area to truly know and am making an assumption with what I currently know
There was a problem hiding this comment.
Seems like we'll only ever get whatever error code maps to that timeout in the 10s bucket.
Any response time > 4s and <= 10s will fall in that 10s bucket
joelanford
dismissed
anik120’s stale review
The suggested change was accepted. Huzzah!
Description
Motivation
Storageimplementation #127