Skip to content
This repository has been archived by the owner on Mar 3, 2025. It is now read-only.

add go-apidiff action #151

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

joelanford
Copy link
Member

No description provided.

Signed-off-by: Joe Lanford <[email protected]>
@joelanford joelanford requested a review from a team as a code owner August 29, 2023 19:27
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #151 (a04c152) into main (8aab690) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files           2        2           
  Lines         157      157           
=======================================
  Hits          125      125           
  Misses         20       20           
  Partials       12       12           

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@joelanford joelanford enabled auto-merge August 30, 2023 14:57
@awgreene
Copy link
Member

awgreene commented Aug 30, 2023

Seems like it works based on it existing and passing in the list of GHA checks.
/approve

@joelanford joelanford added this pull request to the merge queue Aug 30, 2023
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify since I noticed it caused a bit of issues in other repos - this doesn't run as part of the merge queue checks correct?

Merged via the queue into operator-framework:main with commit cd2c38d Aug 30, 2023
@joelanford joelanford deleted the add-go-apidiff branch August 30, 2023 16:26
@grokspawn
Copy link
Contributor

Just to verify since I noticed it caused a bit of issues in other repos - this doesn't run as part of the merge queue checks correct?

Confirm that it will not be run as merge queue, since the on event list includes only pull_request:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants