-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field Subscription.Spec.Config.Annotations #312
Add field Subscription.Spec.Config.Annotations #312
Conversation
75aeb9d
to
60fbe24
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cognifloyd, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 42.64% 42.58% -0.06%
==========================================
Files 42 42
Lines 3583 3588 +5
==========================================
Hits 1528 1528
- Misses 1903 1908 +5
Partials 152 152 ☔ View full report in Codecov by Sentry. |
0eaaa1f
into
operator-framework:master
I need a way to annotate operator deployments to satisfy an admissions hook in my on-prem vanilla (not OCP) k8s clusters (The admissions hook requires annotations that say which team is responsible for that deployment).
After discussing in #olm-dev, it looks like
Subscription
is the best user (cluster admin) facing API to extend for this purpose, as other resources, like CSV, should generally be opaque to the cluster admin.So, this PR adds an
Annotations
field toSubscriptionConfig
(Subscription.Spec.Config.Annotations
). Is there a better place for this? Or a better name?For reference, here is a draft matching change I plan to make in the operator-lifecycle-manager repo once this PR is merged and a new api release is available: