Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-git): Fix including of images #127

Merged
merged 1 commit into from
Nov 25, 2020
Merged

fix(gatsby-source-git): Fix including of images #127

merged 1 commit into from
Nov 25, 2020

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 25, 2020

Change from "raw" git clone to gatsby-source-git introduced a regression where the images are missing on the site.

I went through all the remote repos and all of them features PNG images only, so the added pattern should be sufficient.

Before

image

After

image

@tumido tumido requested a review from durandom November 25, 2020 10:18
@sesheta sesheta requested review from cfchase and hemajv November 25, 2020 10:18
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2020
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@sesheta
Copy link
Member

sesheta commented Nov 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@sesheta sesheta merged commit 10110bd into operate-first:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants