Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network interfaces for access to nfs server #613

Merged
merged 1 commit into from
May 6, 2021
Merged

Add network interfaces for access to nfs server #613

merged 1 commit into from
May 6, 2021

Conversation

larsks
Copy link
Contributor

@larsks larsks commented May 5, 2021

Add network interfaces for access to nfs server

This adds vlan interfaces to provide access to an nfs server for
additional storage. We use node labels to select the appropriate
interface for a given node.

@sesheta sesheta requested review from hemajv and HumairAK May 5, 2021 21:30
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2021
@larsks
Copy link
Contributor Author

larsks commented May 5, 2021

I wasn't sure how to handle the node labels in the context of our management framework. For now I've added them automatically by running the following playbook:

- hosts: openshift
  tasks:
    - delegate_to: localhost
      k8s:
        state: present
        definition:
          apiVersion: v1
          kind: Node
          metadata:
            labels:
              moc/primary-interface: "{{ ansible_default_ipv4.interface }}"
            name: "{{ ansible_hostname }}"

I wasn't sure we wanted to import entire Node resources into our repository for this change (I feel like these may be managed dynamically by OpenShift more than other resources). I wish we had a way to provide a patch to an existing resource (e.g., something that could be applied using oc patch instead of oc apply).

@larsks larsks changed the title master Add network interfaces for access to nfs server May 6, 2021
@larsks larsks mentioned this pull request May 6, 2021
This adds vlan interfaces to provide access to an nfs server for
additional storage. We use node labels to select the appropriate
interface for a given node.

Part of operate-first/SRE#280
@tumido
Copy link
Member

tumido commented May 6, 2021

@larsks seems like we may want to consider something like https://github.com/redhat-cop/resource-locker-operator for locking partial manifests along with ArgoCD. I've started an issue for that here: operate-first/support#235

@tumido
Copy link
Member

tumido commented May 6, 2021

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021
Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta
Copy link
Member

sesheta commented May 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@sesheta sesheta merged commit fe18b9d into operate-first:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants