Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated router costs are not use when evaluating current path cost in the context of smart rerouting #2528

Closed
plorenz opened this issue Nov 9, 2024 · 0 comments
Closed

Updated router costs are not use when evaluating current path cost in the context of smart rerouting #2528

plorenz opened this issue Nov 9, 2024 · 0 comments
Assignees
@plorenz
Labels
controller Issue related to the controller fabric Issue is related to fabric level functionality

Comments

@plorenz
Copy link
Member

plorenz commented Nov 9, 2024

The circuit caches the router and when the router is updated, the router instances in circuits are not updated. So when doing smart re-route, we compare the existing circuit with the old router costs with the new potential paths with the new router costs.
@plorenz plorenz self-assigned this Nov 9, 2024
@plorenz plorenz added controller Issue related to the controller fabric Issue is related to fabric level functionality labels Nov 9, 2024
plorenz added a commit that referenced this issue Nov 12, 2024
@plorenz
Use current router cost when calculating exiting path costs during sm…
f1178d2 
…art reroute. Fixes #2528
plorenz added a commit that referenced this issue Nov 12, 2024
@plorenz
Merge pull request #2531 from openziti/fix-2528
2f82038 
Use current router cost when calculating exiting path costs during smart reroute. Fixes #2528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plorenz plorenz

Labels
controller Issue related to the controller fabric Issue is related to fabric level functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plorenz