Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZITI_ROUTER_ADVERTISED_HOST needs to change to ZITI_ROUTER_ADVERTISED_ADDRESS #1225

Closed
gberl002 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1241
Closed

ZITI_ROUTER_ADVERTISED_HOST needs to change to ZITI_ROUTER_ADVERTISED_ADDRESS #1225

gberl002 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1241
Assignees
@gberl002
Labels
chore documentation Improvements or additions to documentation enhancement New feature or request

Comments

@gberl002
Copy link
Contributor

There was a conflict between the doc and the code using the two different environment variable names for the same value. Due to the easiness of simply updating the script, all values and doc were temporarily changed to refer to ZITI_ROUTER_ADVERTISED_HOST until a new binary can be released.

The variable name should be ZITI_ROUTER_ADVERTISED_ADDRESS to maintain continuity with other variable naming conventions which all use _ADDRESS to refer to the hostname/ip. Doc will need updating when this binary is released.
@gberl002 gberl002 added documentation Improvements or additions to documentation enhancement New feature or request chore labels Jul 27, 2023
@gberl002 gberl002 self-assigned this Jul 28, 2023
gberl002 pushed a commit that referenced this issue Aug 9, 2023
Updating ZITI_ROUTER_ADVERTISED_HOST to use ZITI_ROUTER_ADVERTISED_AD…
6e7f3d0 
…DRESS to match other similarly named objects

closes #1225

Signed-off-by: gberl002 <[email protected]>
@gberl002 gberl002 mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gberl002 gberl002

Labels
chore documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating ZITI_ROUTER_ADVERTISED_HOST to ZITI_ROUTER_ADVERTISED_ADDRESS openziti/ziti
1 participant
@gberl002