enable building rh9 rpm with shared openssl #799
Conversation
|
Clarification: this change makes it possible for us to test the OpenSSL build using the CPack builder machinery. This does not change the release build to OpenSSL from static Mbed-TLS. |
| @@ -45,6 +45,7 @@ done | |||
| --preset "${cmake_preset}" \ | |||
| -DCMAKE_BUILD_TYPE="${cmake_config}" \ | |||
| -DBUILD_DIST_PACKAGES=ON \ | |||
| "${TLSUV_TLSLIB:+-DTLSUV_TLSLIB=${TLSUV_TLSLIB}}" \ | |||
There was a problem hiding this comment.
Why do this for redhat-9 only? If this is just a quick trick for us then maybe a comment here to explain the purpose.
Is there any value in doing it for other distros (keeping in mind that just setting TLSUV_TLSLIB to openssl is only sufficient on distros that already have libssl3 - other distros will also need "openssl" to be added to vcpkg.json).
There is one downside to this and I'm not sure how to handle it. "mbedtls" is currently defined as a dependency in vcpkg.json, which means that vcpkg will download and build mbedtls whether or not the build actually uses it (which is determined by TLSUV_TLSLIB).
There was a problem hiding this comment.
I extended the TLS lib override to RedHat9 so I could try to reproduce the enrollment problem in #517 (comment).
I see what you mean about building Mbed-TLS unnecessarily. I see how to temporarily remove it from vcpkg's deps list, or to replace it with "openssl" for building it statically for distros with libssl v1.
No description provided.