Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vcpkg baseline used in CI package workflow #759

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

scareything
Copy link
Member

No description provided.

@scareything scareything requested a review from a team as a code owner November 21, 2023 16:00
@@ -20,6 +20,7 @@
#include <ziti/ziti_tunnel.h>

#define DNS_NO_ERROR 0
#define DNS_SERVFAIL 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change how ZET's nameserver responds to hits or misses?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this change is benign as no code uses the SERVFAIL symbol. I didn't intend to include this file in the comment, and it will be backed out shortly.

Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It raised a question for me about the nameserver change, and I see this fixes the CI package workflow.

@scareything scareything merged commit 4f99491 into main Nov 21, 2023
8 checks passed
@scareything scareything deleted the fix.ci.package.workflow branch November 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants