bump oidc callback buffer, log access token content #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
reviewed
Jan 15, 2025
| @@ -816,6 +816,25 @@ int oidc_client_close(oidc_client_t *clt, oidc_close_cb cb) { | |||
| return 0; | |||
| } | |||
|
|
|||
| static const char *jwt_payload(const char *jwt) { | |||
| static uint8_t payload[4096]; | |||
There was a problem hiding this comment.
imo, seems like it would be better to pass the length or use a #define ?
dovholuknf
reviewed
Jan 15, 2025
| @@ -825,7 +844,12 @@ static void oidc_client_set_tokens(oidc_client_t *clt, json_object *tok_json) { | |||
| if (clt->token_cb) { | |||
| struct json_object *access_token = json_object_object_get(clt->tokens, "access_token"); | |||
| if (access_token) { | |||
| clt->token_cb(clt, OIDC_TOKEN_OK, json_object_get_string(access_token)); | |||
| const char *token = json_object_get_string(access_token); | |||
| ZITI_LOG(DEBUG, "access_token=%s", jwt_payload(token)); | |||
There was a problem hiding this comment.
this will be really useful to debug! thx
dovholuknf
reviewed
Jan 15, 2025
| @@ -502,7 +502,7 @@ static void ext_accept(uv_work_t *wr) { | |||
| return; | |||
| } | |||
|
|
|||
| char buf[1024]; | |||
| char buf[4096]; | |||
There was a problem hiding this comment.
some tokens are bigger than others... :)
There was a problem hiding this comment.
this does not get receive token
dovholuknf
approved these changes
Jan 15, 2025
ekoby
added a commit
to openziti/ziti-tunnel-sdk-c
that referenced
this pull request
Jan 16, 2025
- fix error when the last message header is zero-length (openziti/ziti-sdk-c#810) - bump oidc callback buffer, log access token content (openziti/ziti-sdk-c#809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.