Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #331 always fetch CA bundle on enrollment #342

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fixes #331 always fetch CA bundle on enrollment #342

merged 1 commit into from
Jan 5, 2023

Conversation

andrewpmartinez
Copy link
Member

No description provided.

@andrewpmartinez andrewpmartinez requested a review from a team as a code owner December 6, 2022 15:44
@qrkourier
Copy link
Member

I'm concerned that introducing this change will cause newly-created identities to have the id.ca property defined with the well-known bundle from the controller and that most SDKs will subsequently insist that server certs are verifiable with that bundle because it is present and fail when the server cert is from a third-party that's not in the bundle, like when an alt cert from Let's Encrypt is presented.

@qrkourier qrkourier mentioned this pull request Dec 9, 2022
Closed
@andrewpmartinez andrewpmartinez merged commit 2cdd4d0 into main Jan 5, 2023
@andrewpmartinez andrewpmartinez deleted the always.fetch.cas.on.enroll branch January 5, 2023 15:18
@potto007 potto007 mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekoby ekoby ekoby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewpmartinez @qrkourier @ekoby