Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for injecting secrets as environment variables (ziti-controller chart) #235

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

mguthrie88
Copy link
Member

Allow secrets to be injected as environment variables from the values file:

secrets:
  - name: SOME_SECRET_ENV
    valueFrom:
      secretKeyRef:
        name: some-secret
        key: some_secret_key

Helm doesn't support secret compilation in the values file, but this method will replicate the secret config into the configMap so that it renders correctly in the environment.

Changes committed by mguthrie88 in commit:  altered the Helm Chart.
I updated the "version" in Chart.yaml file using the "patch" strategy.

Signed-off-by: github-bot[bot] <[email protected]>
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should work perfectly this way. I had one naming suggestion.

charts/ziti-controller/templates/deployment.yaml Outdated Show resolved Hide resolved
@qrkourier qrkourier merged commit ffb69ea into main Jul 23, 2024
1 check passed
@qrkourier qrkourier deleted the env_secrets_block branch July 23, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants