ports dependency linker to javascript #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow integrations including: * single trace aggregates * aggregates across the results of the current query Right now, this is a direct and complete port of the Java code. However, we could do more later once this is integrated. Here are some options: * include references to each span in the dependency link * Ex. trace/span id key so that you can jump directly to the row. * full path tracing (future) * Ex. instead of parent/child, complete path from root to each leaf. See #2701 See #2622 See #2230
This was referenced Aug 3, 2019
zeagord
approved these changes
Aug 8, 2019
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
This should allow integrations including: * single trace aggregates * aggregates across the results of the current query Right now, this is a direct and complete port of the Java code. However, we could do more later once this is integrated. Here are some options: * include references to each span in the dependency link * Ex. trace/span id key so that you can jump directly to the row. * full path tracing (future) * Ex. instead of parent/child, complete path from root to each leaf. See openzipkin#2701 See openzipkin#2622 See openzipkin#2230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow integrations including:
Right now, this is a direct and complete port of the Java code. However,
we could do more later once this is integrated. Here are some options:
See #2701
See #2622
See #2230