Update babel version #2659

tacigar · 2019-07-13T07:45:46Z

Update babel version to babel 7.

codefromthecrypt · 2019-07-13T07:49:40Z

any motivation for this, except keeping current?

tacigar · 2019-07-13T07:50:13Z

zipkin-lens/babel.config.js

+        chrome: '67',
+        safari: '11.1',
+      },
+      useBuiltIns: 'usage',


useBuiltIns option configures how @babel/preset-env handles polyfills.

Please see:

https://babeljs.io/docs/en/babel-preset-env#usebuiltins

https://babeljs.io/docs/en/babel-preset-env#usebuiltins-usage (about usage option)

tacigar · 2019-07-13T07:52:48Z

zipkin-lens/babel.config.js

+        safari: '11.1',
+      },
+      useBuiltIns: 'usage',
+      corejs: 3,


If useBuiltIns options is specified, corejs options should be specified.
3 is corejs version which we use.

Please see:

https://babeljs.io/docs/en/babel-preset-env#corejs

tacigar · 2019-07-13T07:55:09Z

zipkin-lens/babel.config.js

@@ -0,0 +1,18 @@
+const presets = [
+  [
+    '@babel/env',


We can use shorthand name (whole name is @babel/preset-env).

Please see:

https://babeljs.io/docs/en/v7-migration#package-renames

tacigar · 2019-07-13T07:55:34Z

zipkin-lens/babel.config.js

+      corejs: 3,
+    },
+  ],
+  '@babel/react',


This is shorthand name too.
Whole name is @babel/preset-react.

…cies

tacigar · 2019-07-13T08:03:10Z

zipkin-lens/package.json

@@ -88,6 +88,7 @@
    "react-virtualized": "^9.21.1",
    "redux": "^4.0.0",
    "redux-thunk": "^2.3.0",
+    "regenerator-runtime": "^0.13.2",


We need to install core-js & regenerator-runtime for using polyfill.

Please see:

https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#usebuiltins-usage-with-corejs-3

tacigar · 2019-07-13T08:04:49Z

zipkin-lens/package.json

@@ -68,8 +68,8 @@
    "@material-ui/core": "^4.1.1",
    "@material-ui/pickers": "^3.1.1",
    "@material-ui/styles": "^4.1.1",
-    "babel-polyfill": "^6.26.0",


@babel/polyfill (babel-polyfill) is deprecated.
Please see the top of this page (https://babeljs.io/docs/en/babel-polyfill)

tacigar · 2019-07-13T08:06:05Z

zipkin-lens/src/index.js

@@ -18,8 +18,6 @@ import App from './components/App';

 import '../scss/main.scss';

-require('babel-polyfill');


We don't need import polyfill modules anymore.
Babel will do it automatically.

tacigar · 2019-07-13T08:35:41Z

Keeping current is main motivation.
And avoiding to import unused polyfill modules and reducing the amount of code are my motivation too.

codefromthecrypt · 2019-07-13T09:09:20Z

messages like this from travis


[ERROR]     /home/travis/build/openzipkin/zipkin/zipkin-lens/src/components/MiniTimeline/MiniTimelineGraph.test.js: Unexpected token (23:6)

tacigar · 2019-07-14T01:32:13Z

I changed the babel config file from .baberc to babel.config.js.
But Jest did not read the new config file due to cache...
This is the cause of the above error.

I tried to test with --ci option.

codefromthecrypt · 2019-07-14T01:33:23Z

also you can delete cache in travis ui

…

On Sun, Jul 14, 2019, 10:32 AM tacigar ***@***.***> wrote: I changed the babel config file from .baberc to babel.config.js. But Jest did not read the new config file due to cache... I tried to test with --ci option. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2659?email_source=notifications&email_token=AAAPVVZDX5FFQ7P7RG2O5TLP7J6Z7A5CNFSM4ICYUX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ34KVI#issuecomment-511165781>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPVV6QH7FYLM2MMZMGXDTP7J6Z7ANCNFSM4ICYUX7Q> .

tacigar · 2019-07-14T01:42:23Z

Ah, I see.
But test seems success now.

[ERROR] PASS src/zipkin/span-row.test.js
[ERROR] PASS src/zipkin/span-cleaner.test.js
[ERROR] PASS src/zipkin/trace.test.js
[ERROR] PASS src/zipkin/clock-skew.test.js
[ERROR] PASS src/zipkin/span-node.test.js
[ERROR] PASS src/components/DiscoverPage/api.test.js
[ERROR] PASS src/reducers/global-search.test.js
[ERROR] PASS src/components/App/SidebarMenuItem.test.js
[ERROR] PASS src/reducers/traces.test.js
[ERROR] PASS src/reducers/dependencies.test.js
[ERROR] PASS src/reducers/trace.test.js
[ERROR] PASS src/actions/traces-action.test.js
[ERROR] PASS src/actions/global-search-action.test.js
[ERROR] PASS src/actions/trace-action.test.js
[ERROR] PASS src/components/GlobalSearch/util.test.js
[ERROR] PASS src/actions/dependencies-action.test.js
[ERROR] PASS src/components/Browser/BrowserResults.test.js
[ERROR] PASS src/reducers/remote-services.test.js
[ERROR] PASS src/components/MiniTimeline/MiniTimeline.test.js
[ERROR] PASS src/components/App/Sidebar.test.js
[ERROR] PASS src/components/MiniTimeline/MiniTimelineSlider.test.js
[ERROR] PASS src/actions/remote-services-action.test.js
[ERROR] PASS src/reducers/spans.test.js
[ERROR] PASS src/components/App/App.test.js
[ERROR] PASS src/components/Browser/sorting.test.js
[ERROR] PASS src/components/MiniTimeline/MiniTimelineLabel.test.js
[ERROR] PASS src/util/trace.test.js
[ERROR] PASS src/actions/spans-action.test.js
[ERROR] PASS src/reducers/autocomplete-values.test.js
[ERROR] PASS src/reducers/autocomplete-keys.test.js
[ERROR] PASS src/reducers/services.test.js
[ERROR] PASS src/actions/autocomplete-values-action.test.js
[ERROR] PASS src/components/Browser/TraceSummary/TraceSummary.test.js
[ERROR] PASS src/actions/autocomplete-keys-action.test.js
[ERROR] PASS src/actions/services-action.test.js
[ERROR] PASS src/components/MiniTimeline/util.test.js
[ERROR] PASS src/components/Browser/Browser.test.js
[ERROR] PASS src/components/DiscoverPage/TraceIdSearchInput.test.js
[ERROR] PASS src/components/Browser/TraceSummary/TraceSummaryUpperBar.test.js
[ERROR] PASS src/actions/trace-viewer.test.js
[ERROR] PASS src/components/App/Layout.test.js
[ERROR] PASS src/components/Browser/TraceSummary/TraceSummaryBar.test.js
[ERROR] PASS src/components/Browser/TraceSummary/TraceSummaryButtons.test.js
[ERROR] PASS src/components/Browser/BrowserHeader.test.js
[ERROR] PASS src/components/MiniTimeline/MiniTimelineTimeMarkers.test.js
[ERROR] PASS src/components/MiniTimeline/MiniTimelineGraph.test.js
[ERROR] 
[ERROR] Test Suites: 46 passed, 46 total
[ERROR] Tests:       264 passed, 264 total
[ERROR] Snapshots:   0 total
[ERROR] Time:        17.383s
[ERROR] Ran all test suites.

The reason why log is ERROR is the spec of frontend-maven-plugin.

eirslett/frontend-maven-plugin#584

tacigar · 2019-07-14T01:52:20Z

zipkin-lens/package.json

    "@fortawesome/fontawesome-free": "^5.4.1",
-    "babel-core": "^6.26.3",
+    "babel-core": "^7.0.0-bridge.0",


This package is necessary.

↓ Jest 23.6's document
https://github.com/facebook/jest/blob/770799779fc853ab6285727e8938efd06e694d5f/README.md#using-babel

tacigar · 2019-07-14T13:55:49Z

PTAL 🙇

codefromthecrypt · 2019-07-15T00:14:51Z

thank you!

tacigar added 2 commits July 13, 2019 16:07

Update babel packages and configs

e9e420b

Remove unused babel plugin

c95af5d

tacigar commented Jul 13, 2019

View reviewed changes

Move corejs and regenerator-runtime to depenedencies from devDependen…

0ccc8a2

…cies

tacigar commented Jul 13, 2019

View reviewed changes

codefromthecrypt approved these changes Jul 13, 2019

View reviewed changes

Add babel-core-7.0.0-bridge.0 and Add --ci option to jest command

a7c8002

tacigar commented Jul 14, 2019

View reviewed changes

tacigar added techdebt ui Zipkin UI labels Jul 14, 2019

Add npm run test-dev

9b44adf

codefromthecrypt merged commit ea4cd5f into openzipkin:master Jul 15, 2019

tacigar deleted the tacigar/update-babel branch August 3, 2019 16:38

abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019

Update babel version (openzipkin#2659)

a2f8e08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update babel version #2659

Update babel version #2659

tacigar commented Jul 13, 2019

codefromthecrypt commented Jul 13, 2019

tacigar Jul 13, 2019

tacigar Jul 13, 2019

tacigar Jul 13, 2019

tacigar Jul 13, 2019

tacigar Jul 13, 2019

tacigar Jul 13, 2019 •

edited

Loading

tacigar Jul 13, 2019

tacigar commented Jul 13, 2019

codefromthecrypt commented Jul 13, 2019

tacigar commented Jul 14, 2019 •

edited

Loading

codefromthecrypt commented Jul 14, 2019 via email

tacigar commented Jul 14, 2019

tacigar Jul 14, 2019 •

edited

Loading

tacigar commented Jul 14, 2019

codefromthecrypt commented Jul 15, 2019

		@@ -18,8 +18,6 @@ import App from './components/App';

		import '../scss/main.scss';

		require('babel-polyfill');

Update babel version #2659

Update babel version #2659

Conversation

tacigar commented Jul 13, 2019

codefromthecrypt commented Jul 13, 2019

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar Jul 13, 2019 • edited Loading

Choose a reason for hiding this comment

tacigar Jul 13, 2019

Choose a reason for hiding this comment

tacigar commented Jul 13, 2019

codefromthecrypt commented Jul 13, 2019

tacigar commented Jul 14, 2019 • edited Loading

codefromthecrypt commented Jul 14, 2019 via email

tacigar commented Jul 14, 2019

tacigar Jul 14, 2019 • edited Loading

Choose a reason for hiding this comment

tacigar commented Jul 14, 2019

codefromthecrypt commented Jul 15, 2019

tacigar Jul 13, 2019 •

edited

Loading

tacigar commented Jul 14, 2019 •

edited

Loading

tacigar Jul 14, 2019 •

edited

Loading