-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: alpine 3.19.1 #85
Conversation
@@ -17,7 +17,7 @@ ARG docker_parent_image=ghcr.io/openzipkin/alpine:3.19.0 | |||
# When updating, also update the README | |||
# * Use current version from https://pkgs.alpinelinux.org/packages?name=openjdk21, stripping | |||
# the `-rX` at the end. | |||
ARG java_version=21.0.1_p12 | |||
ARG java_version=21.0.2_p13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like 21.0.2_p13-r2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above the line? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or sorry, my bad
@reta hmm odd.. I wonder if there's an non-determinism issue in the package selection, as you can see 21.0.1 in the breaks part despite the ultimate expression used being
|
I think we don't need to separately add the jmods things, because it is already a dependency of the jdk |
Signed-off-by: Adrian Cole <[email protected]>
493ef5c
to
8eb44dd
Compare
can someone with an x86 machine, run from this branch |
Yeah, it confused (and derailed) me as well, not sure what is happening |
I think it is repository order, since openjdk is now not only in edge/community.. will do a quick change to verify, then maybe update the base layer |
No issues on Linux with |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
lol force-broken-world just doesn't do anything |
Signed-off-by: Adrian Cole <[email protected]>
so this isn't about 3.19.1 as same error reverting to 3.19.0... there's something funny and I don't think it is the mirror as I already switched that. Maybe something changed in the runner 🤷 |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
ok it had to do with the github workflow run. basically it ran install twice, once with a slightly older patch and then again with the current one. I guess the change in build-args isn't tainting the layers? |
Signed-off-by: Adrian Cole <[email protected]>
ok good to go. sorry about the thrash, I forgot build-arg cache invalidation behavior |
also fixes the test job so that it doesn't cache layers when it shouldn't due to differing build args. Signed-off-by: Adrian Cole <[email protected]>
I also updated the description, but re-tagging the image will only update the alpine layer as latest JRE is the same build as before.