Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: alpine 3.19.1 #85

Merged
merged 14 commits into from
Feb 7, 2024
Merged

deps: alpine 3.19.1 #85

merged 14 commits into from
Feb 7, 2024

Conversation

codefromthecrypt
Copy link
Member

I also updated the description, but re-tagging the image will only update the alpine layer as latest JRE is the same build as before.

@@ -17,7 +17,7 @@ ARG docker_parent_image=ghcr.io/openzipkin/alpine:3.19.0
# When updating, also update the README
# * Use current version from https://pkgs.alpinelinux.org/packages?name=openjdk21, stripping
# the `-rX` at the end.
ARG java_version=21.0.1_p12
ARG java_version=21.0.2_p13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like 21.0.2_p13-r2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above the line? :D

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or sorry, my bad

@codefromthecrypt
Copy link
Member Author

@reta hmm odd.. I wonder if there's an non-determinism issue in the package selection, as you can see 21.0.1 in the breaks part despite the ultimate expression used being ~openjdk21-jdk-21.0.2_p13 and ~openjdk21-jmods-21.0.2_p13 (where the tilde says get this prefix, which we need because it reduces maintenance when there's a package re-do)

 0.943 ERROR: unable to select packages:
0.945   openjdk21-jmods-21.0.2_p13-r2:
0.945     breaks: world[openjdk21-jmods~21.0.1_p12]
0.945     satisfies: openjdk21-jdk-21.0.2_p13-r2[openjdk21-jmods]
0.945   openjdk21-jdk-21.0.2_p13-r2:
0.945     breaks: world[openjdk21-jdk~21.0.1_p12]

@codefromthecrypt
Copy link
Member Author

I think we don't need to separately add the jmods things, because it is already a dependency of the jdk
https://pkgs.alpinelinux.org/package/edge/community/x86_64/openjdk21-jdk Maybe this will reduce the issue

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

codefromthecrypt commented Feb 7, 2024

can someone with an x86 machine, run from this branch ./build-bin/test 21.0.2_p13? from my macbook zero issues, but obviously something is happening here on x86, and not sure if there's some change in the runner or if something else is at play

@reta
Copy link

reta commented Feb 7, 2024

@reta hmm odd.. I wonder if there's an non-determinism issue in the package selection, as you can see 21.0.1 in the breaks part despite the ultimate expression used being ~openjdk21-jdk-21.0.2_p13 and ~openjdk21-jmods-21.0.2_p13 (where the tilde says get this prefix, which we need because it reduces maintenance when there's a package re-do)

Yeah, it confused (and derailed) me as well, not sure what is happening

@codefromthecrypt
Copy link
Member Author

I think it is repository order, since openjdk is now not only in edge/community.. will do a quick change to verify, then maybe update the base layer

@reta
Copy link

reta commented Feb 7, 2024

can someone with an x86 machine, run from this branch ./build-bin/test 21.0.2_p13? from my macbook zero issues, but obviously something is happening here on x86, and not sure if there's some change in the runner or if something else is at play

No issues on Linux with ./build-bin/test 21.0.2_p13 for me

Adrian Cole added 9 commits February 7, 2024 08:37
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

lol force-broken-world just doesn't do anything

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

so this isn't about 3.19.1 as same error reverting to 3.19.0... there's something funny and I don't think it is the mirror as I already switched that. Maybe something changed in the runner 🤷

Adrian Cole added 2 commits February 7, 2024 10:08
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

ok it had to do with the github workflow run. basically it ran install twice, once with a slightly older patch and then again with the current one. I guess the change in build-args isn't tainting the layers?

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

ok good to go. sorry about the thrash, I forgot build-arg cache invalidation behavior

@codefromthecrypt codefromthecrypt merged commit effbc94 into master Feb 7, 2024
2 checks passed
@codefromthecrypt codefromthecrypt deleted the alpine-3.19.1 branch February 7, 2024 03:29
codefromthecrypt added a commit that referenced this pull request Feb 7, 2024
also fixes the test job so that it doesn't cache layers when it shouldn't due to differing build args.

Signed-off-by: Adrian Cole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants