Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for multi-arch build failures #15

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

llinder
Copy link
Member

@llinder llinder commented Sep 7, 2021

Enables buildx in an attempt to resolve issue #14

@codefromthecrypt
Copy link
Member

might be a good solution though I want to look carefully and understand why. Incidentally, the overlapping architecture problem was one motivation for disabling buildx!

@llinder
Copy link
Member Author

llinder commented Sep 7, 2021

Seems to be related to this pull request which I found while reading issue1170. The thread is fairly long and I don't full grasp the real issue here either. I check the manifest with docker manifest inspect ghcr.io/openzipkin/alpine:3.12.1 and arm64 exists. Seems like that PR now adds a warning that matches the exact message the build fails on invalid from flag value code: image with reference sha256:0804f89bf751879de277f04b8a2874502bbd4bceb12e7688394d9d64837bf7e7 was found but does not match the specified platform: wanted linux/arm64, actual: linux/amd64. Even though the comments say it's a Warning, the Docker build step seems to treat this as a hard failure. I will keep reading, maybe there is a way to ignore the warning in the build step but so far the only thing that I can get to work locally is to use buildx.

Enables buildx in an attempt to resolve issue openzipkin#14
Also removes ryuk overrides as the issue has since been resolved
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@codefromthecrypt codefromthecrypt merged commit ec1bf9e into openzipkin:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants