Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Streams helper operations #833

Merged
merged 19 commits into from
Dec 11, 2018
Merged

Kafka Streams helper operations #833

merged 19 commits into from
Dec 11, 2018

Conversation

jeqo
Copy link
Member

@jeqo jeqo commented Nov 26, 2018

Additional operations to include in KafkaStreamsTracing API to enable easier adoption of tracing as part of a Kafka Streams topology by emulating most-common operations (e.g. KStream#map, KStream#mapValues, KStream#foreach, KStream#peek) with Stream Transformers and Processors that have tracing enabled.

Changes:

KafkaStreamTracing operations added:

  • ProcessorSupplier<K, V> foreach(String name, ForeachAction<K, V> action)
  • TransformerSupplier<K, V, KeyValue<K, V>> peek(String name, ForeachAction<K, V> action)
  • TransformerSupplier<K, V, KeyValue<K, V>> mark(String name)
  • TransformerSupplier<K, V, KeyValue<KR, VR>> map(String name, KeyValueMapper<K, V, KeyValue<KR, VR>> mapper)
  • ValueTransformerWithKeySupplier<K, V, VR> mapValues(String name, KeyValueMapper<K, V, VR> mapper)
  • ValueTransformerSupplier<V, VR> mapValues(String name, ValueMapper<V, VR> mapper)

Ref #825

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. had some documentation questions. Also, make sure the apis being wrapped are stable so we don't cause a rev-lock. Not sure if they are or not.

@jeqo
Copy link
Member Author

jeqo commented Nov 27, 2018

loving suggestions function :)

@jeqo jeqo changed the title [WIP] Kafka Streams helper operations Kafka Streams helper operations Nov 27, 2018
@codefromthecrypt codefromthecrypt merged commit be36b31 into openzipkin:master Dec 11, 2018
@codefromthecrypt
Copy link
Member

Thanks as always @jeqo and @ImFlog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants