-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Streams helper operations #833
Merged
codefromthecrypt
merged 19 commits into
openzipkin:master
from
jeqo:kafka-streams-wrapper
Dec 11, 2018
Merged
Kafka Streams helper operations #833
codefromthecrypt
merged 19 commits into
openzipkin:master
from
jeqo:kafka-streams-wrapper
Dec 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. had some documentation questions. Also, make sure the apis being wrapped are stable so we don't cause a rev-lock. Not sure if they are or not.
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
ImFlog
reviewed
Nov 27, 2018
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/KafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
…s/KafkaStreamsTracing.java Co-Authored-By: jeqo <[email protected]>
loving suggestions function :) |
jeqo
changed the title
[WIP] Kafka Streams helper operations
Kafka Streams helper operations
Nov 27, 2018
codefromthecrypt
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional operations to include in
KafkaStreamsTracing
API to enable easier adoption of tracing as part of a Kafka Streams topology by emulating most-common operations (e.g.KStream#map
,KStream#mapValues
,KStream#foreach
,KStream#peek
) with Stream Transformers and Processors that have tracing enabled.Changes:
KafkaStreamTracing
operations added:ProcessorSupplier<K, V> foreach(String name, ForeachAction<K, V> action)
TransformerSupplier<K, V, KeyValue<K, V>> peek(String name, ForeachAction<K, V> action)
TransformerSupplier<K, V, KeyValue<K, V>> mark(String name)
TransformerSupplier<K, V, KeyValue<KR, VR>> map(String name, KeyValueMapper<K, V, KeyValue<KR, VR>> mapper)
ValueTransformerWithKeySupplier<K, V, VR> mapValues(String name, KeyValueMapper<K, V, VR> mapper)
ValueTransformerSupplier<V, VR> mapValues(String name, ValueMapper<V, VR> mapper)
Ref #825