Re-enables errorprone on JDK 10+ #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the commandline instructions here: http://errorprone.info/docs/installation However, there's a glitch as I'm not sure why `-XepDisableWarningsInGeneratedCode` doesn't work. See google/error-prone#860
pom.xml
Outdated
| <annotationProcessorPaths> | ||
| <processorPath> | ||
| <groupId>com.google.errorprone</groupId> | ||
| <artifactId>error_prone_ant</artifactId> |
There was a problem hiding this comment.
do we really need the ant classifier? or will core work?
pom.xml
Outdated
| <arg>-XDcompilePolicy=simple</arg> | ||
| <arg>-Xplugin:ErrorProne</arg> | ||
| <!-- TODO: why does this not work? --> | ||
| <!--<arg>-XepDisableWarningsInGeneratedCode</arg>--> |
There was a problem hiding this comment.
this crashes when uncommented:
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] javac: invalid flag: -XepDisableWarningsInGeneratedCode
Usage: javac <options> <source files>
use --help for a list of possible options
warning: [options] bootstrap class path not set in conjunction with -source 1.8
There was a problem hiding this comment.
You need to put all the Error Prone flags in the same <arg> as -Xplugin:ErrorProne like
<arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode</arg>
Here's an example from another project I work on that uses Error Prone as a compiler plugin: https://github.com/TechEmpower/tfb-status/blob/e3e1c5d2684252d2ad585545016c98574bf78e81/pom.xml#L451-L534
There was a problem hiding this comment.
thanks tons. all good now!
|
Works with the problem of crashing on args (commented about this) $ ./mvnw clean compile -pl brave
--snip--
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ brave ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 50 source files to /Users/acole/oss/brave/brave/target/classes
[WARNING] [options] bootstrap class path not set in conjunction with -source 1.8
[WARNING] WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.bugpatterns.FutureReturnValueIgnored (file:/Users/acole/.m2/repository/com/google/errorprone/error_prone_ant/2.3.1/error_prone_ant-2.3.1.jar) to field com.sun.tools.javac.code.Type$StructuralTypeMapping$4.this$0
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.bugpatterns.FutureReturnValueIgnored
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
/Users/acole/oss/brave/brave/src/main/java/brave/propagation/ThreadLocalSpan.java:[99,6] [ThreadLocalUsage] ThreadLocals should be stored in static fields
(see http://errorprone.info/bugpattern/ThreadLocalUsage)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.289 s
[INFO] Finished at: 2018-08-20T09:38:30+08:00
[INFO] ------------------------------------------------------------------------ |
|
oops also need to figure our how to disable this in certain sub-projects, like JMH (instrumentation/benchmarks) |
|
all sorted.. thanks @michaelhixson! |
|
circleci is angry for unrelated reasons |
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Aug 20, 2018
It is a little tricky to get errorprone and auto-value working at the same time. See openzipkin/brave#761
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Aug 21, 2018
It is a little tricky to get errorprone and auto-value working at the same time. See openzipkin/brave#761
codefromthecrypt
pushed a commit
to openzipkin-attic/zipkin-classic
that referenced
this pull request
May 17, 2019
It is a little tricky to get errorprone and auto-value working at the same time. See openzipkin/brave#761
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
It is a little tricky to get errorprone and auto-value working at the same time. See openzipkin/brave#761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the commandline instructions here:
http://errorprone.info/docs/installation
See google/error-prone#860