WIP: Support for 128 bit TraceIDs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR has been tested with 64 bit traceID Zipkin instance and is backwards compatible if tracing with 128 bit traceIDs by simply having the high bits of the traceID be ignored. Sampling functionality is also solely on the low 64 bits. This PR will be merged once Zipkin backend supports 128 bit TraceIDs. |
basvanbeek
force-pushed
the
128bit-traceid
branch
from
be388ad to
6e96c18
Compare
|
I ran the example against snapshot zipkin and looks great! |
|
ps for those unacclimated, here's what I did to test.. |
|
awesome... sounds like merge time to me! |
codefromthecrypt
pushed a commit
to openzipkin/brave
that referenced
this pull request
Oct 27, 2016
Traditionally, Zipkin trace IDs were 64-bit. Starting with Zipkin 1.14, 128-bit trace identifiers are supported. This can be useful in sites that have very large traffic volume, persist traces forever, or are re-using externally generated 128-bit IDs. If you want Brave to generate 128-bit trace identifiers when starting new root spans, set `Brave.Builder.traceId128Bit(true)` When 128-bit trace ids are propagated, they will be twice as long as before. For example, the `X-B3-TraceId` header will hold a 32-character value like `163ac35c9f6413ad48485a3953bb6124`. Before doing this, ensure your Zipkin setup is up-to-date, and downstream instrumented services can read the longer 128-bit trace IDs. Note: this only affects the trace ID, not span IDs. For example, span ids within a trace are always 64-bit. See openzipkin/zipkin#1298 See openzipkin-contrib/zipkin-go-opentracing#31
richardmarshall
pushed a commit
to richardmarshall/zipkin-go-opentracing
that referenced
this pull request
Dec 13, 2016
…rtcard Minor fixes to appease formatting and linting tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the ability of the tracer to work with 128 bit TraceIDs.
See: openzipkin/zipkin#1298