Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for converter properties #233

Closed
wants to merge 2 commits into from

Conversation

richterdavid
Copy link

Initial take on addressing issue 123, for feedback.

@richterdavid
Copy link
Author

I'd like feedback on the approach, formatting, and whether logged property names should reflect the variable names in the code or the property names in https://wiki.openzim.org/wiki/Metadata. If the latter, I may need some guidance on the mapping. For example, I suspect that main_url maps to Source, but this isn't made clear in the source code.

@rgaudin
Copy link
Member

rgaudin commented Apr 18, 2024

I think metadata should match libzim or use the notation we use in self.creator.config_metadata( (see below in the same file). Keep in mind those can be modified so printing too early might not be the best approach

@benoit74
Copy link
Collaborator

Closing it, nothing will have to be done at warc2zim level, see openzim/python-scraperlib#155

@benoit74 benoit74 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants