Adding new tests to libzim

[Rishabhg71]

I have added the -s DISABLE_EXCEPTION_CATCHING=0 to compile the files properly.

[Rishabhg71]

is it okay to let the GitHub actions run? I am seeing some steps where files may be updated on server

[Rishabhg71]

@Jaifroid Tests are now enabled on all the build files + could you answer my question above?

[Jaifroid]

@Rishabhg71 I'm sorry, I didn't see the notifications from your previous message and query. You can run GitHub actions. "Build and publish release artefacts" (https://github.com/openzim/javascript-libzim/actions/workflows/build_libzim_wasm.yml) explains what it does in the Run Workflow dropdown. I you run it as "nightly", then it will create artefacts and upload them to the nightly server. If you run it as "release" but without a version number, then it will just build artefacts and archive them under the workflow summary. If you add a version number, then it will create a draft release in releases (which can simply be deleted if it's a test run).

"Upload release assets to Kiwix" only runs after a draft release is published. So no need to worry about it if you're not actually pressing the "Publish" button on a draft release!

[Jaifroid]

Forgot to add that automatic running of workflows when changes to a PR are pushed only produce archived versions under the workflow, they don't publish them to the Kiwix server, so it's safe to let the workflow complete after push, or to re-run it.

[Rishabhg71]

A difference between the production and the debug builds is that the latter have -s DISABLE_EXCEPTION_CATCHING=0 in the compile command. For more info, see https://emscripten.org/docs/porting/exceptions.html#emscripten-javascript-based-exception-support .
Rather than compiling the production versions with enabled exception catching, we should make use of https://github.com/emscripten-core/emscripten/blob/main/src/settings.js#L683 (EXCEPTION_CATCHING_ALLOWED = [ ]) to enable catching only in the affected function(s).

How do I know which functions should be passed as a parameter? I think getEntryByPath is the only function or am I wrong?

[Jaifroid]

@Rishabhg71 The functions for which we have written bindings are the articleCount, search, and getDirectoryByPath. We need to write some more, but they're not urgent, because we handle everything else in the backend ourselves currently,

[Rishabhg71]

@Jaifroid I have added -s EXCEPTION_CATCHING_ALLOWED=["getEntryByPath","search","getArticleCount","loadArchive"] but seems like I still that uncaught error. I am not sure why this is happening any idea? building with -s DISABLE_EXCEPTION_CATCHING=0 is working fine

[Jaifroid]

@Rishabhg71 I'm afraid I don't know, and I've never used that setting allowing exception catching for individual functions. I would say that if the size of the bundle is not significantly increased by the general setting, it's probably safe to use it, unless you can find some info on how to get the narrower exception catching working...

[Rishabhg71]

I think the size is good enough it has only increased 20 kb max, files with suffix "1" are compiled byDISABLE_EXCEPTION_CATCHING. I have limited experience, I did some googling and prompting but didn't get any further

If this is acceptable I think then you can do a first review now

[Jaifroid]

OK, thanks, I'll review it, but in the meantime, you might want to revert the individual exception catching, which is still in the PR and is not working, right? Certainly the tests have failed, not 100% sure if it¡'s for that reason.

[Jaifroid]

It's all looking good to me -- well written code! Just the few queries below, and I'd like to see a run passing with both Ray Charles and Stackexchange being tested.

[Rishabhg71]

@Jaifroid Sorry I forgot to revert my changes, you can check again

[Jaifroid]

Looks very good to me, with just the two small changes below! After this is merged, we should create a new release, so that we can use officially released artefacts over at Kiwix JS.