ZTS: Don't use ext4 unless on Linux #9914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And while here, add a workaround for FreeBSD to ensure dirty data is synced before taking a snapshot, by remounting read-only, then remount again read-write after the snapshot. Signed-off-by: Ryan Moeller <[email protected]>
ghost
added
Component: Test Suite
ghost
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9914 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 384 384
Lines 121788 121788
========================================
+ Hits 96645 96647 +2
+ Misses 25143 25141 -2
Continue to review full report at Codecov.
|
|
for example = https://bitbucket.org/dilos/dilos-illumos/src/dilos2/usr/src/test/zfs-tests/tests/functional/rsend/send-wDR_encrypted_zvol.ksh |
jwk404
approved these changes
Jan 30, 2020
behlendorf
approved these changes
Jan 31, 2020
behlendorf
added
Status: Accepted
ghost
deleted the
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
And while here, add a workaround for FreeBSD to ensure dirty data is synced before taking a snapshot, by remounting read-only, then remount again read-write after the snapshot. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#9914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
EXT4 is a Linux filesystem. Other platforms can use the default FS type.
Description
Similarly to
slog/slog_replay_volume, use the default FS inrsend/send-wDR_encrypted_zvolexcept on Linux, where ext4 is preferred.And while here, add a workaround for FreeBSD to ensure dirty data is synced before taking a snapshot, by remounting read-only, then remount again read-write after the snapshot.
How Has This Been Tested?
This has been running in our ZTS for a while.
Types of changes
Checklist:
Signed-off-by.