Document zfs change-key caveats #9819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlaager
added
Component: Encryption
rlaager
force-pushed
the
document-change-key-caveats
branch
from
ba3d6f3 to
bbc2929
Compare
|
FWIW, the limitations on the compromise of a master key are no different than with LUKS: https://superuser.com/questions/330995/if-an-old-luks-header-with-a-compromised-key-is-recovered-can-it-be-used-to-rea |
PrivatePuffin
approved these changes
Jan 7, 2020
ahrens
reviewed
Jan 7, 2020
rlaager
force-pushed
the
document-change-key-caveats
branch
2 times, most recently
from
d59a642 to
eca9adf
Compare
Codecov Report
@@ Coverage Diff @@
## master #9819 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 385 385
Lines 121481 121481
========================================
- Hits 96500 96419 -81
- Misses 24981 25062 +81
Continue to review full report at Codecov.
|
ahrens
approved these changes
Jan 8, 2020
behlendorf
approved these changes
Jan 8, 2020
behlendorf
added
Status: Accepted
tcaputi
reviewed
Jan 8, 2020
ghfields
reviewed
Jan 9, 2020
rlaager
force-pushed
the
document-change-key-caveats
branch
2 times, most recently
from
452ae1d to
a92a168
Compare
ghfields
approved these changes
Jan 13, 2020
behlendorf
approved these changes
Jan 13, 2020
As discussed on the 2019-01-07 OpenZFS Leadership Meeting, we need to be clear about the limitations of `zfs change-key`. Changing the user key does not change the master key, nor does it currently overwrite the old wrapped master key on disk. Signed-off-by: Richard Laager <[email protected]>
rlaager
force-pushed
the
document-change-key-caveats
branch
from
a92a168 to
78ec759
Compare
|
I think the current version addresses all the feedback. |
ahrens
approved these changes
Jan 14, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
As discussed on the 2019-01-07 OpenZFS Leadership Meeting, we need to be clear about the limitations of `zfs change-key`. Changing the user key does not change the master key, nor does it currently overwrite the old wrapped master key on disk. Reviewed-by: Tom Caputi <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matt Ahrens <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Garrett Fields <[email protected]> Reviewed-by: Kjeld Schouten <[email protected]> Signed-off-by: Richard Laager <[email protected]> Closes openzfs#9819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As discussed on the 2019-01-07 OpenZFS Leadership Meeting, we need to be
clear about the limitations of
zfs change-key. Changing the user keydoes not change the master key, nor does it currently overwrite the old
wrapped master key on disk.
Description
This documents the caveats in the
zfs change-keysection of the zfs-load-key.8 man page.How Has This Been Tested?
I reviewed the output with
man.Types of changes
Checklist:
Signed-off-by.