Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-0.8.3 patchset #9776

Closed
wants to merge 175 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
48d1439
make zil max block size tunable
ahrens Jun 10, 2019
6894c2e
single-chunk scatter ABDs can be treated as linear
ahrens Jun 11, 2019
193d598
looping in metaslab_block_picker impacts performance on fragmented pools
ahrens Jun 13, 2019
0701572
OpenZFS 9425 - channel programs can be interrupted
Jun 22, 2019
320dad7
Fix bp_embedded_type enum definition
loli10K Jun 25, 2019
4879d2b
Concurrent small allocation defeats large allocation
pcd1193182 Jun 26, 2019
8a8bedc
OpenZFS 9318 - vol_volsize_to_reservation does not account for raidz …
Jun 30, 2019
12ffb25
Don't activate metaslabs with weight 0
pcd1193182 Jul 5, 2019
9b68e14
install path fixes
c0d3z3r0 Jul 30, 2019
5ecf5c1
Add channel program for property based snapshots
clinta Jul 30, 2019
30d4c3f
lockdep false positive - move txg_kick() outside of ->dp_lock
jdike Jul 31, 2019
2881be3
Test cancelling a removal in ZTS
sdimitro Aug 5, 2019
9eaec88
Don't wakeup unnecessarily in 'zpool events -f'
DeHackEd Aug 5, 2019
450c2ac
Drop KMC_NOEMERGENCY
ryao Aug 13, 2019
e440d00
Change boolean-like uint8_t fields in znode_t to boolean_t
kusumi Aug 13, 2019
dde7231
spa_load_verify() may consume too much memory
grwilson Aug 13, 2019
0cc3501
Fix device expansion when VM is powered off
Aug 14, 2019
5b9b8fb
Prevent race in blkptr_verify against device removal
pcd1193182 Aug 14, 2019
9bbd7fa
Make txg_wait_synced conditional in zfsvfs_teardown
PaulZ-98 Aug 15, 2019
086204d
Assert that a dnode's bonuslen never exceeds its recorded size
sdimitro Aug 15, 2019
f546fe1
Improve write performance by using dmu_read_by_dnode()
tonynguien Aug 15, 2019
addec6e
dmu_tx_wait() hang likely due to cv_signal() in dsl_pool_dirty_delta()
sdimitro Aug 15, 2019
b3714cd
initramfs: fixes for (debian) initramfs
c0d3z3r0 Aug 16, 2019
1a0b849
Add more refquota tests
pcd1193182 Aug 19, 2019
e6f9948
Set "none" scheduler if available (initramfs)
colmbuckley Aug 19, 2019
55205ca
Fix lockdep circular locking false positive involving sa_lock
jdike Aug 19, 2019
7076958
zfs-functions.in: in_mtab() always returns 1
fling- Aug 20, 2019
dca5ee7
Minor cleanup in Makefile.am
Aug 21, 2019
3c4e1df
ZTS: Fix vdev_zaps_005_pos on CentOS 6
behlendorf Aug 22, 2019
86dbc24
Enhance ioctl number checks
Aug 22, 2019
84c96ae
Dedup IOC enum values in libzfs_input_check
Aug 22, 2019
3569769
Document ZFS_DKMS_ENABLE_DEBUGINFO in userland configuration
mfoliveira Aug 22, 2019
0af3a0a
Fix install error introduced by #9089
pcd1193182 Aug 22, 2019
30ab789
ZTS: Fix in-tree dbufstats test case
behlendorf Aug 23, 2019
1232cbd
Split argument list, satisfy shellcheck SC2086
Aug 26, 2019
20213e6
Add regression test for "zpool list -p"
pcd1193182 Aug 26, 2019
44fa089
Prefer `for (;;)` to `while (TRUE)`
Aug 28, 2019
a8a23a1
Use smaller default slack/delta value for schedule_hrtimeout_range()
tonynguien Aug 28, 2019
06000ce
Use compatible arg order in tests
Aug 29, 2019
d962046
Simplify deleting partitions in libtest
Aug 29, 2019
f187167
Prevent metaslab_sync panic due to spa_final_dirty_txg
pcd1193182 Aug 30, 2019
eaa2c56
Fix refquota_007_neg.ksh
ikozhukhov Aug 30, 2019
7236378
Fix typos in config/
Gelma Aug 30, 2019
9539c54
Fix typos in man/
Gelma Aug 30, 2019
623efe8
Fix typos in cmd/
Gelma Aug 30, 2019
b893d3d
Fix typos in contrib/
Gelma Aug 30, 2019
f17e686
Fix typos in etc/
Gelma Aug 30, 2019
86e39e5
Fix typos in include/
Gelma Aug 30, 2019
62e2fa2
Fix typos in modules/icp/
Gelma Aug 30, 2019
b4f1f80
Fix typos in module/
Gelma Aug 30, 2019
9049c64
Fix typos in tests/
Gelma Aug 30, 2019
5b55ca1
Fix typos in tests/
Gelma Aug 30, 2019
d3dfad5
Fix typos in lib/
Gelma Sep 3, 2019
1259fe6
Fix typos in module/zfs/
Gelma Sep 3, 2019
6c7aa9f
Fix typos in tests/
Gelma Sep 3, 2019
4f0c337
Fix typos in tests/
Gelma Sep 3, 2019
575d45d
Fix typos in tests/
Gelma Sep 3, 2019
a0267fc
Fix typos in tests/
Gelma Sep 3, 2019
682d095
Fix typos in tests/
Gelma Sep 3, 2019
e01cf9b
Fix typos in tests/
Gelma Sep 3, 2019
8ec5be3
Fix typos in tests/
Gelma Sep 3, 2019
74ec792
Fix typos
Gelma Sep 3, 2019
92c4bc0
maxinflight can overflow in spa_load_verify_cb()
grwilson Sep 3, 2019
7adf9ee
ZTS: Fix removal_cancel.ksh
ikozhukhov Sep 3, 2019
80caf3f
Fix panic on DilOS with kstat per dataset statistics
ikozhukhov Sep 3, 2019
ea5f806
Use the right booleans
Sep 3, 2019
a503fb8
Refactor checksum operations in tests
Sep 5, 2019
563b5fb
Clean up zfs_clone_010_pos
Sep 5, 2019
186abea
Fix noop receive of raw send stream
Sep 5, 2019
842e387
Clean up do_vol_test in zfs_copies tests
Sep 9, 2019
546e443
ZTS: Introduce targeted corruption in file blocks
jwk404 Sep 9, 2019
91e1543
Fix stalled txg with repeated noop scans
Sep 11, 2019
76063fc
Canonicalize Python shebangs
Sep 12, 2019
b58a354
Fix clone handling with encryption roots
Sep 16, 2019
3ee9480
ZTS: Fix /usr/bin/env: 'python2': No such file or directory
loli10K Sep 16, 2019
432c508
Device removal of indirect vdev panics the kernel
loli10K Sep 16, 2019
8dd0c4c
Refactor libzfs_error_init newlines
Sep 18, 2019
49f7f24
Use signed types to prevent subtraction overflow
Sep 22, 2019
484a9d4
diff_cb() does not handle large dnodes
loli10K Sep 24, 2019
37bf226
Add warning for zfs_vdev_elevator option removal
behlendorf Sep 25, 2019
be8749f
ZTS: harden xattr/cleanup.ksh
behlendorf Sep 25, 2019
ed3d9f4
Linux 5.0 compat: SIMD compatibility
behlendorf Jul 12, 2019
be71dd1
SIMD: Use alloc_pages_node to force alignment
Fabian-Gruenbichler Dec 10, 2019
f74461d
Perform KABI checks in parallel
behlendorf Oct 1, 2019
5656c13
Fix for zfs-dracut regression
dacianstremtan Oct 1, 2019
c1f0f26
Workaround to avoid a race when /var/lib is a persistent dataset
didrocks Oct 2, 2019
1ed0d0e
ZTS: Fix upgrade_readonly_pool
behlendorf Oct 3, 2019
b386dfd
Rename rangelock_ functions to zfs_rangelock_
mattmacy Oct 3, 2019
87a9a6f
Fix automount for root filesystems
behlendorf Oct 4, 2019
97f224e
ZTS: Fix trim/trim_config and trim/autotrim_config
behlendorf Oct 4, 2019
c20b0fa
module/Makefile.in: don't run xargs if empty
gmelikov Oct 8, 2019
6e5ba87
ZTS: Fix mmp_hostid test
ikozhukhov Oct 8, 2019
5d211cc
Update `zfs program` command usage
behlendorf Oct 10, 2019
1a143b2
Fix pool creation with feature@allocation_classes disabled
loli10K Oct 10, 2019
08c0b75
Fix some style nits in tests
Oct 11, 2019
9ab63e2
Clarify loop variable name in zfs copies test
Oct 11, 2019
08410c2
Implement ZPOOL_IMPORT_UDEV_TIMEOUT_MS
ryao Oct 9, 2019
5d5faa3
ZTS: Fix zpool_status_-s
behlendorf Oct 11, 2019
d2fb93b
Modify sharenfs=on default behavior
behlendorf Oct 14, 2019
6946a52
Update skc_obj_alloc for spl kmem caches that are backed by Linux
sdimitro Oct 18, 2019
4db8ddd
Name anonymous enum of KMC_BIT constants
sdimitro Oct 18, 2019
ac67de2
ZTS: Written props test fails with 4k disks
jwk404 Oct 18, 2019
d8cd6a8
Use correct format string when printing int8
mattmacy Oct 21, 2019
2ca4787
ZTS: Consistency pass for .ksh extensions
Oct 24, 2019
27ff6fc
Fix incremental recursive encrypted receive
Oct 24, 2019
bb230d9
Fix zpool history unbounded memory usage
davidchenntnx Oct 28, 2019
9216e78
Fix 'zfs change-key' with unencrypted child
Oct 30, 2019
9ea68a8
Fix contrib/zcp/Makefile.am
behlendorf Oct 30, 2019
d0486fb
dracut/zfs-load-key.sh: properly remove prefixes
alaviss Oct 30, 2019
fcf3a2e
Include prototypes for vdev_initialize
mattmacy Oct 31, 2019
bf53985
Add a notice in /etc/defaults/zfs for systemd users
cdluminate Nov 6, 2019
5077db6
Skip loading already loaded key
vozhyk- Nov 8, 2019
382aeaf
Improve logging of 128KB writes
amotin Nov 11, 2019
c885930
Fix `zpool create -o <property>` error message
behlendorf Nov 13, 2019
e0ecb41
Add missing documentation for some KMC flags
c0d3z3r0 Jul 21, 2019
2456817
Prevent NULL pointer dereference in blkg_tryget() on EL8 kernels
loli10K Nov 13, 2019
7552de5
Change zed.service to zfs-zed.service in man page
Nov 13, 2019
58b5847
Remove inappropiate error message suggesting to use '-r'
InsanePrawn Nov 15, 2019
1a4c107
Break out of zfs_zget early if unlinked znode
hrasiq Nov 15, 2019
18b36a7
Remove requirement for -d 1 for zfs list and zfs get with bookmarks
InsanePrawn Nov 19, 2019
5d175b7
ZTS: Casenorm fix unicode interpretation
gmelikov Nov 20, 2019
8d14009
ZTS: tst.terminate_by_signal increase test threshold
behlendorf Nov 21, 2019
5c0fa51
Check for unlinked znodes after igrab()
mfoliveira Nov 21, 2019
16e496c
Add display of checksums to zdb -R
PaulZ-98 Nov 27, 2019
4f096ec
Remove zfs_vdev_elevator module option
behlendorf Nov 27, 2019
5c2c1cd
Implement -A (ignore ASSERTs) for zdb
PaulZ-98 Nov 27, 2019
cbb83dd
Fix small typo in systemd mount generator
InsanePrawn Nov 22, 2019
9f51a04
Fix non-absolute path in systemd mount generator
InsanePrawn Nov 23, 2019
c8c7095
Fix encryption logic in systemd mount generator
InsanePrawn Nov 22, 2019
03a7336
Adapt gitignore for modules
c0d3z3r0 Dec 2, 2019
44bc323
Increase allowed 'special_small_blocks' maximum value
behlendorf Dec 3, 2019
f05d403
Fix use-after-free in case of L2ARC prefetch failure
amotin Dec 3, 2019
eca8d1f
Fix zdb_read_block using zio after it is destroyed
PaulZ-98 Dec 3, 2019
7ec60f1
Fix reporting of L2ARC hits/misses in arc_summary3
gamanakis Dec 4, 2019
8c9a572
Set send_realloc_files.ksh to use properties.shlib
Dec 6, 2019
ba9c024
ZTS: Fix zpool_reopen_001_pos
behlendorf Dec 9, 2019
74dec73
Exclude data from cores unconditionally and metadata conditionally
mattmacy Dec 9, 2019
e26ecd4
zio_decompress_data always ASSERTs successful decompression
PaulZ-98 Dec 10, 2019
4ecbf33
Fix use-after-free of vd_path in spa_vdev_remove()
ahrens Dec 11, 2019
fbe4bd9
Allow empty ds_props_obj to be destroyed
Dec 13, 2019
48849e4
Don't fail to apply umask for O_TMPFILE files
kusumi Dec 13, 2019
1420f55
initramfs: setup keymapping and video for prompts
rlaager Dec 17, 2019
d61ee3e
Force systems with kernel option "quiet" to display prompt for password
ghfields Dec 18, 2019
d37bea0
Create symbolic links in /dev/disk/by-vdev for nvme disk devices
geppi Dec 18, 2019
8341b1c
Exchanged two "${ZFS} get -H -o value" commands
ghfields Dec 18, 2019
564cb85
cppcheck: (error) Uninitialized variable
Dec 13, 2019
b76be31
cppcheck: (error) Uninitialized variable
Dec 14, 2019
35e157c
cppcheck: (error) Shifting signed 64-bit value by 63 bits
Dec 14, 2019
0c3c858
cppcheck: (error) Memory leak: vtoc
behlendorf Dec 16, 2019
8b6657c
cppcheck: (warning) Possible null pointer dereference: dnp
behlendorf Dec 16, 2019
5a9ab4b
cppcheck: (error) Null pointer dereference: who_perm
behlendorf Dec 16, 2019
6154c07
cppcheck: (error) Address of local auto-variable assigned
behlendorf Dec 16, 2019
6f98f60
cppcheck: (warning) Possible null pointer dereference: nvh
behlendorf Dec 17, 2019
e102aee
Fix for ARC sysctls ignored at runtime
loli10K Dec 28, 2019
3a7d795
ZTS: Various test case fixes
behlendorf Dec 19, 2019
6463bc3
Update maximum kernel version to 5.4
behlendorf Dec 23, 2019
4059d0f
ZTS: Test case failures
behlendorf Dec 26, 2019
f23c406
Cancel initialize and TRIM before vdev_metaslab_fini()
behlendorf Dec 26, 2019
ac44630
libspl: declare aok extern in header
dankamongmen Dec 26, 2019
9b64145
In initramfs, do not prompt if keylocation is "file://"
sam-lunt Dec 26, 2019
0f30b5e
Avoid some crashes when importing a pool with corrupt metadata
smokris Dec 26, 2019
8bbdf83
ZTS: devices_001_pos and devices_002_neg
behlendorf Dec 27, 2019
162a2ec
ZTS: zfs_program_json
behlendorf Dec 27, 2019
2f3d42b
ZTS: Replace /var/tmp with $TEST_BASE_DIR
behlendorf Dec 28, 2019
ce740ee
ZTS: Fix pool_state cleanup
behlendorf Dec 28, 2019
8372bf3
zfs-load-key.sh: ${ZFS} is not the zfs binary
bencord0 Dec 29, 2019
e0a87b8
zdb: print block checksums with 6 d's of verbosity
nedbass Dec 30, 2019
4ad592c
ZTS: Cleanup partition tables
behlendorf Jan 6, 2020
ad3dbdf
Fix zfs-0.8.3 'make lint' warnings
tonyhutter Jan 7, 2020
9111fe2
Fix zfs-0.8.3 zfs_receive_raw test case
tonyhutter Jan 3, 2020
8d26607
Fix QAT allocation failure return value
behlendorf Jan 6, 2020
f5ff772
Prevent unnecessary resilver restarts
jwpoduska Nov 27, 2019
6c5fc8e
ZTS: Fixes for spurious failures of resilver_restart_001 test
jwpoduska Dec 10, 2019
81cd142
Fix zfs-0.8.3 "qat.h"
tonyhutter Jan 22, 2020
e4bd681
Tag zfs-0.8.3
tonyhutter Dec 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cancel initialize and TRIM before vdev_metaslab_fini()
Any running 'zpool initialize' or TRIM must be cancelled prior
to the vdev_metaslab_fini() call in spa_vdev_remove_log() which
will unload the metaslabs and set ms->ms_group == NULL.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Kjeld Schouten <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #8602
Closes #9751
behlendorf authored and tonyhutter committed Jan 7, 2020
commit f23c4068286fc23472e11ad51d7c921cdcf9012a
13 changes: 7 additions & 6 deletions module/zfs/vdev_removal.c
Original file line number Diff line number Diff line change
@@ -1861,6 +1861,13 @@ spa_vdev_remove_log(vdev_t *vd, uint64_t *txg)
spa_vdev_config_exit(spa, NULL,
*txg + TXG_CONCURRENT_STATES + TXG_DEFER_SIZE, 0, FTAG);

/*
* Cancel any initialize or TRIM which was in progress.
*/
vdev_initialize_stop_all(vd, VDEV_INITIALIZE_CANCELED);
vdev_trim_stop_all(vd, VDEV_TRIM_CANCELED);
vdev_autotrim_stop_wait(vd);

/*
* Evacuate the device. We don't hold the config lock as
* writer since we need to do I/O but we do keep the
@@ -1891,12 +1898,6 @@ spa_vdev_remove_log(vdev_t *vd, uint64_t *txg)
vdev_metaslab_fini(vd);

spa_vdev_config_exit(spa, NULL, *txg, 0, FTAG);

/* Stop initializing and TRIM */
vdev_initialize_stop_all(vd, VDEV_INITIALIZE_CANCELED);
vdev_trim_stop_all(vd, VDEV_TRIM_CANCELED);
vdev_autotrim_stop_wait(vd);

*txg = spa_vdev_config_enter(spa);

sysevent_t *ev = spa_event_create(spa, vd, NULL,