ZTS: devices_001_pos and devices_002_neg #9773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Component: Test Suite
Update the devices_001_pos and devices_002_neg test cases such that the special block device file created is backed by a ZFS volume. Specifying a specific device allows the major and minor numbers to be easily determined. Furthermore, this avoids the potentially dangerous behavior of opening the first block device we happen to find under /dev/. Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf
force-pushed
the
zts-devices
branch
from
9560b52 to
cdfb704
Compare
Codecov Report
@@ Coverage Diff @@
## master #9773 +/- ##
==========================================
+ Coverage 67% 80% +13%
==========================================
Files 303 385 +82
Lines 104240 121475 +17235
==========================================
+ Hits 69658 96888 +27230
+ Misses 34582 24587 -9995
Continue to review full report at Codecov.
|
ghost
approved these changes
Dec 27, 2019
I'd like to keep it, presumably at some point we'll want to enable this test case for FreeBSD. |
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 2, 2020
Update the devices_001_pos and devices_002_neg test cases such that the special block device file created is backed by a ZFS volume. Specifying a specific device allows the major and minor numbers to be easily determined. Furthermore, this avoids the potentially dangerous behavior of opening the first block device we happen to find under /dev/. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#9773
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 7, 2020
Update the devices_001_pos and devices_002_neg test cases such that the special block device file created is backed by a ZFS volume. Specifying a specific device allows the major and minor numbers to be easily determined. Furthermore, this avoids the potentially dangerous behavior of opening the first block device we happen to find under /dev/. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#9773
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Update the devices_001_pos and devices_002_neg test cases such that the special block device file created is backed by a ZFS volume. Specifying a specific device allows the major and minor numbers to be easily determined. Furthermore, this avoids the potentially dangerous behavior of opening the first block device we happen to find under /dev/. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #9773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The way the
devices_001_posanddevices_002_negtests wereoriginal written and then ported has resulted ZTS failures when running
in environment with only NVMe devices. Update the test case so they
no longer need to grub around in the /dev/ directory to determine the
major and minor numbers to be used.
Description
Update the
devices_001_posanddevices_002_negtest cases such that thespecial block device file created is backed by a ZFS volume. Specifying
a specific device allows the major and minor numbers to be easily
determined. Furthermore, this avoids the potentially dangerous behavior
of opening the first block device we happen to find under
/dev/.How Has This Been Tested?
Manually tested in the problematic environment as configured by the CI.
For this initial PR I've restricted the ZTS tags run to those I've observed
fail in the CI without this change. Assuming the CI confirms all is will
I'll resubmit this for a full ZTS run.
Types of changes
Checklist:
Signed-off-by.