-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ASSERTV macro with compiler annotation #9671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I can use
on Windows, so at least there is a way. |
behlendorf
reviewed
Dec 4, 2019
ed64397
to
696c7f8
Compare
behlendorf
reviewed
Dec 4, 2019
9787324
to
e2e9a52
Compare
Signed-off-by: Matt Macy <[email protected]>
e2e9a52
to
949f892
Compare
behlendorf
approved these changes
Dec 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #9671 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 418 418
Lines 123562 123568 +6
========================================
- Hits 98093 98068 -25
- Misses 25469 25500 +31
Continue to review full report at Codecov.
|
behlendorf
pushed a commit
that referenced
this pull request
Dec 6, 2019
Followup for #9671, remove stale comment. Reviewed-by: Kjeld Schouten <[email protected]> Reviewed-by: Jorgen Lundman <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Matt Macy <[email protected]> Issue #9671 Closes #9682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Macy [email protected]
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.