Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ASSERTV macro with compiler annotation #9671

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Dec 4, 2019

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@lundman
Copy link
Contributor

lundman commented Dec 4, 2019

Looks like I can use

#define		__debug __pragma(warning(suppress: 4100 4101))

on Windows, so at least there is a way.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 4, 2019
@behlendorf behlendorf requested a review from lundman December 4, 2019 00:54
include/os/linux/spl/sys/debug.h Outdated Show resolved Hide resolved
lib/libspl/include/sys/debug.h Outdated Show resolved Hide resolved
module/os/linux/zfs/zfs_vnops.c Outdated Show resolved Hide resolved
module/zfs/dsl_dataset.c Outdated Show resolved Hide resolved
module/zfs/txg.c Outdated Show resolved Hide resolved
@mattmacy mattmacy force-pushed the projects/__debug branch 2 times, most recently from ed64397 to 696c7f8 Compare December 4, 2019 02:41
include/os/linux/spl/sys/debug.h Outdated Show resolved Hide resolved
lib/libspl/include/sys/debug.h Outdated Show resolved Hide resolved
@mattmacy mattmacy force-pushed the projects/__debug branch 4 times, most recently from 9787324 to e2e9a52 Compare December 4, 2019 20:58
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #9671 into master will decrease coverage by <1%.
The diff coverage is 95%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9671    +/-   ##
========================================
- Coverage      79%      79%   -<1%     
========================================
  Files         418      418            
  Lines      123562   123568     +6     
========================================
- Hits        98093    98068    -25     
- Misses      25469    25500    +31
Flag Coverage Δ
#kernel 80% <97%> (ø) ⬇️
#user 67% <91%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12395c7...949f892. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 5, 2019
@behlendorf behlendorf merged commit 2a8ba60 into openzfs:master Dec 5, 2019
behlendorf pushed a commit that referenced this pull request Dec 6, 2019
Followup for #9671, remove stale comment.

Reviewed-by: Kjeld Schouten <[email protected]>
Reviewed-by: Jorgen Lundman <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Issue #9671 
Closes #9682
@mattmacy mattmacy deleted the projects/__debug branch December 19, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants