Update ZFS_IOC offsets for FreeBSD

[mattmacy]

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.

[allanjude]

Reviewed By: Allan Jude [email protected]

[behlendorf]

Looks like you may have forgotten to include the matching ./tests/zfs-tests/cmd/libzfs_input_check/libzfs_input_check.c changes.

[mattmacy]

./tests/zfs-tests/cmd/libzfs_input_check/libzfs_input_check.

Fixed.

[behlendorf]

Before we officially commit this range by using these reserved values let's check with @lundman. We may want to reserve smaller groups of 32 to leave space for MacOS and windows.

[lundman]

Ok, on OSX:
+ 0xD0 and we define one (ZFS_IOC_PROXY_DATASET)

On Windows:
+ 0xE0 and we define three (ZFS_IOC_MOUNT. ZFS_IOC_UNMOUNT, ZFS_IOC_UNREGISTER_FS)

Unfortunately, Windows ioctls are a bit weird (they go up by increments of +4), so I had to spell them out:

https://github.com/openzfsonwindows/ZFSin/blob/master/ZFSin/zfs/include/sys/zfs_ioctl.h#L533

The CTL_CODE macro shifts the "index" << 2, hence the +4. So the Windows table might have to be separate, unless there is something clever we can do?

[lundman]

(Hmm and I should probably fix that lone ZFS_IOC_RECV_NEW o_O )

[behlendorf]

Well these don't have to be entirely consistent across platforms, it more for our own convenience when reserving values. It sound like it may make the most sense for windows to do its own thing when we get to that point.

[behlendorf]

Well these don't have to be entirely consistent across platforms, it more for our own convenience when reserving values. It sound like it may make the most sense for windows to do its own thing when we get to that point.

[codecov]

Codecov Report

Merging #9667 into master will increase coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #9667    +/-   ##
========================================
+ Coverage      79%      79%   +<1%     
========================================
  Files         418      418            
  Lines      123562   123562            
========================================
+ Hits        98093    98177    +84     
+ Misses      25469    25385    -84

Flag	Coverage Δ
#kernel	80% <ø> (ø)	⬆️
#user	67% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12395c7...45a0975. Read the comment docs.