Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attach-o_ashift.ksh for multiplatforms #9636

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

ikozhukhov
Copy link
Contributor

Signed-off-by: Igor Kozhukhov [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@PrivatePuffin
Copy link
Contributor

You should REALLY start filling out your PR forms.

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #9636 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9636      +/-   ##
==========================================
+ Coverage   79.19%   79.24%   +0.05%     
==========================================
  Files         418      418              
  Lines      123531   123531              
==========================================
+ Hits        97828    97891      +63     
+ Misses      25703    25640      -63
Flag Coverage Δ
#kernel 79.92% <ø> (+0.07%) ⬆️
#user 66.89% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c46813...a6d6b4e. Read the comment docs.

Copy link
Contributor

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this seems a nice KISS fix.
However:

  • To keep the repo readable, please fillout the PR form and describe why this change was needed.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 27, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 27, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf merged commit a7c3588 into openzfs:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants