Avoid running exportfs on each zfs/zpool command invocation #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunnarbeutner Since you originally wrote this code can you comment on this patch. |
|
The change itself makes perfect sense (and should fix some of the problems when running zfs/zpool as a non-root user) and the patch looks sane. I'm all for merging it into the master branch. |
|
The fundamental change looks good to me as well. Although, I think we'll want to rework a few bits here and there. I'll make comments inline. |
Delay executing exportfs command until its results are actually required. Signed-off-by: Cyril Plisko <[email protected]>
|
I have reworked the commit a bit as requested. Although I've implemented nfs_available() function a little bit differently. I hope it is somewhat more clear that way that nfs_export_temp_fd value is focal point for nfs availability decision. |
|
Thank you, this is much better. I'll get it merged. |
|
Merged as commit 27ccd41 |
gunnarbeutner
pushed a commit
to gunnarbeutner/zfs
that referenced
this pull request
Oct 30, 2012
… iostat' output Reviewed by: Adam Leventhal <[email protected]> Reviewed by: Matt Ahrens <[email protected]> Reviewed by: Eric Schrock <[email protected]> Reviewed by: Dan McDonald <[email protected]> Reviewed by: Garrett D'Amore <[email protected]> Approved by: Eric Schrock <[email protected]> Refererce to Illumos issue: https://www.illumos.org/issues/952 Ported-by: Richard Yao <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#607
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Sep 26, 2023
…s#952) Bumps [itertools](https://github.com/rust-itertools/itertools) from 0.10.5 to 0.11.0. - [Changelog](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) - [Commits](rust-itertools/itertools@v0.10.5...v0.11.0) --- updated-dependencies: - dependency-name: itertools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay executing exportfs command until its results are actually
required.