ZTS: Consistency pass for .ksh extensions #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use .ksh extension for ksh scripts, not .sh * Remove .ksh extension from tests in common.run Signed-off-by: Ryan Moeller <[email protected]>
ghost
added
Component: Test Suite
behlendorf
approved these changes
Oct 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #9502 +/- ##
==========================================
- Coverage 79.15% 79.08% -0.07%
==========================================
Files 416 416
Lines 123655 123655
==========================================
- Hits 97876 97790 -86
- Misses 25779 25865 +86
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
ghost
deleted the
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
* Use .ksh extension for ksh scripts, not .sh * Remove .ksh extension from tests in common.run Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#9502
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
* Use .ksh extension for ksh scripts, not .sh * Remove .ksh extension from tests in common.run Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#9502
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
* Use .ksh extension for ksh scripts, not .sh * Remove .ksh extension from tests in common.run Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes #9502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There is one test script that is named *.sh even though it has /bin/ksh as the shebang.
All the other ksh test scripts are named *.ksh.
There are a few occurrences in common.run where the .ksh extension is included in the test case name. These are inconsistent with the convention of not specifying extensions in the runfile.
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.