Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rangelock_ functions to zfs_rangelock_ #9402

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Oct 2, 2019

A rangelock KPI already exists on FreeBSD.

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

A rangelock KPI already exists on FreeBSD.

Signed-off-by: Matt Macy <[email protected]>
@mattmacy mattmacy force-pushed the projects/rangelock branch from aa57ac3 to 388bdc8 Compare October 2, 2019 23:24
Copy link
Contributor

@ikozhukhov ikozhukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like zfs specific rename to be a more portable! :)
thanks for update.

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #9402 into master will increase coverage by 12.51%.
The diff coverage is 82.6%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9402       +/-   ##
===========================================
+ Coverage   66.62%   79.13%   +12.51%     
===========================================
  Files         326      404       +78     
  Lines      105097   122527    +17430     
===========================================
+ Hits        70017    96965    +26948     
+ Misses      35080    25562     -9518
Flag Coverage Δ
#kernel 79.82% <82.6%> (?)
#user 66.5% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae8b2a...388bdc8. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 3, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 3, 2019
@behlendorf behlendorf merged commit 2cc479d into openzfs:master Oct 3, 2019
@mattmacy mattmacy deleted the projects/rangelock branch December 19, 2019 22:28
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
A rangelock KPI already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#9402
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
A rangelock KPI already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#9402
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
A rangelock KPI already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes #9402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants