Fix-for-zfs-dracut-regression-#8913 #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 31 and 32 overwrote the ${root} variable which broke mount-zfs.sh
Signed-off-by: Dacian Reece-Stremtan <[email protected]>
behlendorf
added
Component: Dracut
Codecov Report
@@ Coverage Diff @@
## master #9379 +/- ##
==========================================
+ Coverage 79.02% 79.06% +0.03%
==========================================
Files 403 403
Lines 122539 122539
==========================================
+ Hits 96838 96887 +49
+ Misses 25701 25652 -49
Continue to review full report at Codecov.
|
ghfields
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks. Looks like a reasonable way to implement what @tsandmann discussed in #8913 (comment)
behlendorf
approved these changes
Oct 1, 2019
behlendorf
added
Status: Accepted
|
Is this fix part of the next zfs release for centos 7.7? |
|
Yes, I've added it to the tracking list. |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
Line 31 and 32 overwrote the ${root} variable which broke mount-zfs.sh
We have create a new variable for the dataset instead of overwriting the
${root} variable in zfs-load-key.sh${root} variable in zfs-load-key.sh
Reviewed-by: Kash Pande <[email protected]>
Reviewed-by: Garrett Fields <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Dacian Reece-Stremtan <[email protected]>
Closes openzfs#8913
Closes openzfs#9379
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Line 31 and 32 overwrote the ${root} variable which broke mount-zfs.sh
We have create a new variable for the dataset instead of overwriting the
${root} variable in zfs-load-key.sh${root} variable in zfs-load-key.sh
Reviewed-by: Kash Pande <[email protected]>
Reviewed-by: Garrett Fields <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Dacian Reece-Stremtan <[email protected]>
Closes openzfs#8913
Closes openzfs#9379
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Line 31 and 32 overwrote the ${root} variable which broke mount-zfs.sh
We have create a new variable for the dataset instead of overwriting the
${root} variable in zfs-load-key.sh${root} variable in zfs-load-key.sh
Reviewed-by: Kash Pande <[email protected]>
Reviewed-by: Garrett Fields <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Dacian Reece-Stremtan <[email protected]>
Closes #8913
Closes #9379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 31 and 32 overwrote the ${root} variable which broke mount-zfs.sh
Signed-off-by: Dacian Reece-Stremtan [email protected]
This fixes the issue #8913.
We have create a new variable for the dataset instead of overwriting the ${root} variable in zfs-load-key.sh
Motivation and Context
#8913
Description
How Has This Been Tested?
Create a new initramfs using dracut and restarted the computer. This was done on two separate computers running Centos 7.7
Centos 7.7, zfs 0.8.2
Rebuilt initramfs using dracut on the systems mentioned above. Restarted the system. Instead of failing to start because the root was not mounted (using zfs root), now the computer started all the way.
Fixes problem in mount-zfs.sh where the script is bypassed because the ${root} variable was overwritten in zfs-load-key.sh to hold only the dataset name and not the kernel line option for zfs root.
Types of changes
Checklist:
Signed-off-by.