Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Fix /usr/bin/env: 'python2': No such file or directory #9325

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

loli10K
Copy link
Contributor

@loli10K loli10K commented Sep 15, 2019

Motivation and Context

Recently i lost the ability to run the ZTS on my "golden" builder image (Debian9):

root@linux:~# head config.log 
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by zfs configure 0.8.0, which was
generated by GNU Autoconf 2.69.  Invocation command line was

  $ ./configure --prefix=/usr --sysconfdir=/etc --libdir=/lib64 --enable-debug --with-python=2.7

## --------- ##
## Platform. ##
root@linux:~# sudo -u nobody -s /usr/share/zfs/zfs-tests.sh -d /var/tmp -v -T removal 

--- Configuration ---
Runfile:         /usr/share/zfs/runfiles/linux.run
STF_TOOLS:       /usr/share/zfs/test-runner
STF_SUITE:       /usr/share/zfs/zfs-tests
STF_PATH:        /var/tmp/constrained_path.aZwC
FILEDIR:         /var/tmp
FILES:           /var/tmp/file-vdev0 /var/tmp/file-vdev1 /var/tmp/file-vdev2
LOOPBACKS:       /dev/loop0 /dev/loop1 /dev/loop2 
DISKS:           loop0 loop1 loop2
NUM_DISKS:       3
FILESIZE:        4G
ITERATIONS:      1
TAGS:            removal
STACK_TRACER:    no
Keep pool(s):    rpool
Missing util(s): arc_summary3 mmap_libaio arp bc fio umask wait 

/usr/share/zfs/test-runner/bin/test-runner.py  -c "/usr/share/zfs/runfiles/linux.run" -T "removal" -i "/usr/share/zfs/zfs-tests" -I "1"
/usr/bin/env: 'python2': No such file or directory
/usr/bin/env: 'python2': No such file or directory
root@linux:~# 

Description

Since 4f342e4 env(1) must be able to find a "python2" executable in the "constrained path" on systems configured with --with-python=2.x otherwise the ZFS Test Suite won't be able to use Python scripts.

How Has This Been Tested?

Tested on Debian9 with the following configuration:

./configure --prefix=/usr --sysconfdir=/etc --libdir=/lib64 --enable-debug --with-python=2.7

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Since 4f342e4 env(1) must be able to find a "python2" executable in
the "constrained path" on systems configured with --with-python=2.x
otherwise the ZFS Test Suite won't be able to use Python scripts.

Signed-off-by: loli10K <[email protected]>
@loli10K loli10K added the Status: Work in Progress Not yet ready for general review label Sep 15, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #9325 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9325      +/-   ##
==========================================
+ Coverage   79.02%   79.09%   +0.07%     
==========================================
  Files         401      401              
  Lines      122469   122469              
==========================================
+ Hits        96777    96863      +86     
+ Misses      25692    25606      -86
Flag Coverage Δ
#kernel 79.77% <ø> (-0.02%) ⬇️
#user 66.8% <ø> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0d418...993c0c2. Read the comment docs.

@loli10K loli10K added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Sep 16, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 16, 2019
@behlendorf behlendorf merged commit 7e15647 into openzfs:master Sep 16, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
Since 4f342e4 env(1) must be able to find a "python2" executable in
the "constrained path" on systems configured with --with-python=2.x
otherwise the ZFS Test Suite won't be able to use Python scripts.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes openzfs#9325
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Since 4f342e4 env(1) must be able to find a "python2" executable in
the "constrained path" on systems configured with --with-python=2.x
otherwise the ZFS Test Suite won't be able to use Python scripts.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes openzfs#9325
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Since 4f342e4 env(1) must be able to find a "python2" executable in
the "constrained path" on systems configured with --with-python=2.x
otherwise the ZFS Test Suite won't be able to use Python scripts.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes #9325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants